Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package versions and local path dependencies #2247

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update package versions and local path dependencies #2247

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9308a21
Update package versions and local path dependencies
hallipr Feb 26, 2025
f60c6ae
Add dependency script
hallipr Feb 27, 2025
100555f
Fix deps with versions
hallipr Feb 27, 2025
19e5d58
Use crates.io index
hallipr Feb 28, 2025
ebbd785
Sort versions using AzureEngSemanticVersion class
hallipr Feb 28, 2025
b6c6986
fix property names
hallipr Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
156 changes: 126 additions & 30 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 0 additions & 18 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,41 +29,23 @@ rust-version = "1.80"

[workspace.dependencies.typespec]
default-features = false
path = "sdk/typespec"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this what we decided to do? I thought we were going to leave both. This really needs to be written up somewhere and not locked in our heads. We've waffled about this too much.

That said, this is maybe premature because:

  1. We should test package-workspace and help stabilize that. Seems it'll solve most of our problems and we won't have to have this difficult solution.
  2. Until GA, we'll be rev'ing everything anyway. beta.2 is going to include a massive number of changes because I'm changing azure_core significantly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If anything, maybe we should be keeping the path dependency for the foreseeable future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will we do about late shippers? If workspace is a path dependency and Cosmos takes a workspace dependency, then we can't change core/typespec packages until after cosmos ships. This could block changes in core or typespec for weeks at a time

version = "0.2.0"

[workspace.dependencies.typespec_client_core]
default-features = false
path = "sdk/typespec/typespec_client_core"
version = "0.1.0"

[workspace.dependencies.typespec_macros]
version = "0.1.0"
path = "sdk/typespec/typespec_macros"

[workspace.dependencies.azure_core]
version = "0.22.0"
path = "sdk/core/azure_core"

[workspace.dependencies.azure_core_amqp]
version = "0.1.0"
path = "sdk/core/azure_core_amqp"

[workspace.dependencies.azure_core_test]
version = "0.1.0"
path = "sdk/core/azure_core_test"

[workspace.dependencies.azure_core_test_macros]
version = "0.1.0"
path = "sdk/core/azure_core_test_macros"

[workspace.dependencies.azure_identity]
version = "0.22.0"
path = "sdk/identity/azure_identity"

[workspace.dependencies.azure_storage_common]
version = "0.1.0"
path = "sdk/storage"

[workspace.dependencies]
async-lock = "3.0"
Expand Down
9 changes: 6 additions & 3 deletions sdk/core/azure_core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "azure_core"
version = "0.22.0"
version = "0.23.0"
description = "Rust wrappers around Microsoft Azure REST APIs - Core crate"
readme = "README.md"
authors.workspace = true
Expand Down Expand Up @@ -28,8 +28,11 @@ serde_json.workspace = true
sha2 = { workspace = true, optional = true }
tokio = { workspace = true, optional = true }
tracing.workspace = true
typespec = { workspace = true, features = ["http", "json"] }
typespec_client_core = { workspace = true, features = ["http", "json"] }
typespec = { path = "../../typespec", features = ["http", "json"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all crates should be using path dependencies until GA (or close). See previous comments.

typespec_client_core = { path = "../../typespec/typespec_client_core", features = [
"http",
"json",
] }

[build-dependencies]
rustc_version.workspace = true
Expand Down
Loading
Loading