You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maintainer-facing review assist for the Bitgesell #39 bounty lane:
I checked current head 24f0ea2103500ff4dbfe42939cdfe7ae1724ce09. The diff is narrow: package.json switches the test script from the POSIX-only NODE_ENV=test mocha $npm_package_options_mocha form to node test/run-mocha.js, and the new runner sets NODE_ENV=test, invokes the local Mocha binary through node, preserves the existing Mocha options (--timeout 20000 --recursive --require should), and forwards extra CLI arguments.
Current visible state: PR is OPEN, MERGEABLE, mergeStateStatus=CLEAN, has no top-level comments or reviews, and no status checks are visible on the PR. It looks like a focused cross-platform test-runner fix rather than a runtime/client behavior change.
Pre-merge checks I would use:
Run the author's Windows command (npm test -- test\errors\rpc-error_test.js --reporter spec) plus the same targeted test on a POSIX shell to confirm argument forwarding stays equivalent.
Run npm test without extra args once, because the runner hardcodes the existing options.mocha value instead of reading npm_package_options_mocha dynamically.
Confirm npm run cover still works, since it shells through nyc ... npm test and will now call the node runner.
No claim/payment action from me here; this is just review-routing support so maintainers can evaluate #11 against the active Bitgesell PR bounty queue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NODE_ENV=testin a cross-platform wayVerification
npm test -- test\errors\rpc-error_test.js --reporter specpasses on Windowsgit diff --checkreports no patch whitespace errors; Git only warns thatpackage.json/test/run-mocha.jswill be normalized to CRLF locallyNote:
npm run lint -- --quietcurrently fails on pre-existinglinebreak-styleerrors across the repository on Windows, unrelated to this change.