Fix isolated parser tests for Bitgesell config - #12
Open
cedar323 wants to merge 1 commit into
Open
Conversation
|
Maintainer-facing review assist for the #39 bounty queue: I would treat this as a focused test-fix candidate, not a runtime RPC behavior change. It only touches Acceptance checks I would ask for before merge:
This looks bounty-relevant under BitgesellOfficial/bitgesell#39 because that issue explicitly includes one test group/file fixed by a single PR, but payout/priority still needs maintainer confirmation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitgesell/bitgesellMultiWallettest config keysparser_test.jscan run without a local BGLd/Docker serviceVerification
$env:NODE_ENV='test'; node node_modules\mocha\bin\mocha --timeout 20000 --recursive --require should test\parser_test.js --reporter specpasses on Windowsgit diff --checkreports no patch whitespace errors; Git only warns about local CRLF normalizationNote: this PR is intentionally independent from #11 and only touches
test/parser_test.js.