Skip to content

Fix isolated parser tests for Bitgesell config #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cedar323 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix isolated parser tests for Bitgesell config #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 33 additions & 7 deletions test/parser_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@ afterEach(() => {

describe('Parser', () => {
it('should throw an error with a generic message if one is not returned on the response', async () => {
nock(`http://${config.bitcoin.host}:${config.bitcoin.port}/`)
nock(`http://${config.bitgesell.host}:${config.bitgesell.port}/`)
.post('/')
.reply(200, '{ "result": null, "error": { "code": -32601 }, "id": "69837016239933"}');

try {
await new Client(config.bitcoin).command('foobar');
await new Client(config.bitgesell).command('foobar');

should.fail();
} catch (e) {
Expand All @@ -40,12 +40,12 @@ describe('Parser', () => {
});

it('should throw an error if the response does not include a `result`', async () => {
nock(`http://${config.bitcoin.host}:${config.bitcoin.port}/`)
nock(`http://${config.bitgesell.host}:${config.bitgesell.port}/`)
.post('/')
.reply(200, '{ "error": null, "id": "69837016239933"}');

try {
await new Client(config.bitcoin).command('foobar2');
await new Client(config.bitgesell).command('foobar2');

should.fail();
} catch (e) {
Expand All @@ -56,8 +56,12 @@ describe('Parser', () => {
});

it('should throw an error if the response is not successful but is json-formatted', async () => {
nock(`http://${config.bitgesellMultiWallet.host}:${config.bitgesellMultiWallet.port}/`)
.post('/wallet/foobar')
.reply(200, '{ "result": null, "error": { "code": -18, "message": "Requested wallet does not exist or is not loaded" }, "id": "69837016239933"}');

try {
await new Client(_.defaults({ wallet: 'foobar' }, config.bitcoinMultiWallet)).getWalletInfo();
await new Client(_.defaults({ wallet: 'foobar' }, config.bitgesellMultiWallet)).getWalletInfo();
} catch (e) {
should(e).be.an.instanceOf(RpcError);
should(e.message).equal('Requested wallet does not exist or is not loaded');
Expand All @@ -67,7 +71,16 @@ describe('Parser', () => {

describe('headers', () => {
it('should return the response headers if `headers` is enabled', async () => {
const [info, headers] = await new Client(_.defaults({ headers: true }, config.bitcoin)).getNetworkInfo();
nock(`http://${config.bitgesell.host}:${config.bitgesell.port}/`)
.post('/')
.reply(200, '{ "result": { "version": 180000 }, "error": null, "id": "69837016239933"}', {
connection: 'close',
'content-length': '68',
'content-type': 'application/json',
date: 'Mon, 08 Jun 2026 00:00:00 GMT'
});

const [info, headers] = await new Client(_.defaults({ headers: true }, config.bitgesell)).getNetworkInfo();

should(info).be.an.Object();
should(headers).have.keys('date', 'connection', 'content-length', 'content-type');
Expand All @@ -78,7 +91,20 @@ describe('Parser', () => {
{ method: 'getbalance' },
{ method: 'getbalance' }
];
const [addresses, headers] = await new Client(_.defaults({ headers: true }, config.bitcoin)).command(batch);
nock(`http://${config.bitgesell.host}:${config.bitgesell.port}/`)
.post('/')
.reply(200, (uri, body) => JSON.parse(body).map((request, index) => ({
error: null,
id: request.id,
result: index + 1
})), {
connection: 'close',
'content-length': '107',
'content-type': 'application/json',
date: 'Mon, 08 Jun 2026 00:00:00 GMT'
});

const [addresses, headers] = await new Client(_.defaults({ headers: true }, config.bitgesell)).command(batch);

should(addresses).have.length(batch.length);
should(headers).have.keys('date', 'connection', 'content-length', 'content-type');
Expand Down