Skip to content

UI refactoring, part 2 #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: v0.6
Choose a base branch
from
Draft

UI refactoring, part 2 #1394

wants to merge 14 commits into from

Conversation

g1itch
Copy link
Collaborator

@g1itch g1itch commented Nov 18, 2018 •
edited
Loading

Hello!

In the second part of UI refactoring I moved most of widgets definitions into ui-files, removed autogenerated code and renamed bitmessageui to main.
Minor appearance differences include:

  • Add buttons are not resizing infinitely
  • UPnP checkbox label on tab "Network Settings" of Settings dialog
  • "Resends expire tab" of Settings dialog.

Also maybe I did wrong in retranslateui.

These changes definitely require testing. I'm going to write some soon. But it may make sense to merge this before qt5-wip because of many pylint warnings in obsolete settings and bitmessageui modules.

@g1itch g1itch force-pushed the ui-refactoring branch 6 times, most recently from e8bd0db to dcbad33 Compare November 18, 2018 18:41
@PeterSurda
Copy link
Member

Man this is huge. Does it affect the translation sources? Transifex could delete parts of old translations if they move to a different context.

@PeterSurda
Copy link
Member

It looks ok but I'm not going to review it in detail. I checked translation compiling, and that looks like it doesn't break it. There is one major problem though, when I try to run it, the main window briefly pops up and then it crashes:

Loading existing config files from /home/bitmessage/.config/PyBitmessage/
Gtk-Message: Failed to load module "canberra-gtk-module"
2018-11-19 13:36:25 MainThread namecoin.py@363 /home/bitmessage/.namecoin/namecoin.conf unreadable or missing, Namecoin support deactivated
2018-11-19 13:36:25 MainThread __init__.py@3541 There was a problem testing for a Namecoin daemon. Hiding the Fetch Namecoin ID button
2018-11-19 13:36:25 MainThread __init__.py@965 No indicator plugin found
2018-11-19 13:36:25 MainThread __init__.py@985 No notification.message plugin found
2018-11-19 13:36:30 MainThread namecoin.py@363 /home/bitmessage/.namecoin/namecoin.conf unreadable or missing, Namecoin support deactivated
2018-11-19 13:36:30 MainThread __init__.py@3541 There was a problem testing for a Namecoin daemon. Hiding the Fetch Namecoin ID button
Segmentation fault

@g1itch
Copy link
Collaborator Author

g1itch commented Nov 19, 2018

No, I guess about a half of translations strings will be reset by this changes.

@g1itch g1itch force-pushed the ui-refactoring branch 4 times, most recently from 820228a to 7208ded Compare November 21, 2018 15:36
@g1itch
Copy link
Collaborator Author

g1itch commented Nov 22, 2018

Could you please check again? I removed inheritance of RetranslateMixin.

@PeterSurda
Copy link
Member

No more crash.

@g1itch g1itch mentioned this pull request Dec 13, 2018
Closed
@g1itch g1itch mentioned this pull request Jul 30, 2019
Merged
@g1itch g1itch marked this pull request as draft May 22, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature refactoring translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g1itch @PeterSurda