Skip to content

New Page additions #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kjaymiller opened this issue Sep 30, 2024 · 7 comments · Fixed by #502
Closed

New Page additions #488

kjaymiller opened this issue Sep 30, 2024 · 7 comments · Fixed by #502

Comments

@kjaymiller
Copy link
Contributor

Based on the initial PR of #487 We need to update our MAINTAINERS.MD with this information to make sure we provide it to contributors that need assistance.

When a new page is created there are things that should be included.

  • If a new data type is created then we need a new file in _data/. JSON is preferred but YAML/CSV is also okay.
  • Add the route to tests/conftest in the ROUTES constant.

ROUTES = [
"",
"blog",
"about",
"events",
"community",
"leadership",
]

@kjaymiller kjaymiller added good first issue Good for newcomers content labels Sep 30, 2024
@kjaymiller
Copy link
Contributor Author

@BlackPythonDevs/documentation or @BlackPythonDevs/triage feel free to discuss

@cmm25
Copy link
Contributor

cmm25 commented Oct 1, 2024

kindly assign me this issue.

@dragid10
Copy link
Member

dragid10 commented Oct 2, 2024

  • If a new data type is created then we need a new file in _data/. JSON is preferred but YAML/CSV is also okay.

In what cases would YAML/CSV be accepted as opposed to JSON? If we can define when that scenario would happen, then I think that would reduce confusion for future contributors

@kjaymiller
Copy link
Contributor Author

  • If a new data type is created then we need a new file in _data/. JSON is preferred but YAML/CSV is also okay.

In what cases would YAML/CSV be accepted as opposed to JSON? If we can define when that scenario would happen, then I think that would reduce confusion for future contributors

I think CSV works if we had some data heavy information. I don't think we have anything like that now but I wouldn't want to have some information like annual sponsorship numbers or things in a JSON file (especially since it would be coming from a spreadsheet).

@JohananOppongAmoateng
Copy link
Contributor

@cmm25 are you still working on this issue? Do you need help?

@cmm25
Copy link
Contributor

cmm25 commented Oct 4, 2024

Apologies I was held up this week but will push my branch tomorrow.

@cmm25
Copy link
Contributor

cmm25 commented Oct 5, 2024

Check pr #502. Note I discovered another error that I have explained concerning the ruby version that necessitated me to update it so please also review that

@kjaymiller kjaymiller linked a pull request Oct 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants