Skip to content

Modified the club page #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Sep 30, 2024
Merged

Conversation

Selasi3
Copy link
Contributor

@Selasi3 Selasi3 commented Sep 30, 2024

No description provided.

@kjaymiller
Copy link
Contributor

@Selasi3 - This is great! Good job.

I made a small change that you will need to pull down (Removed the if and endif that wraps most of the content)

  • Something that I noticed is that there isn't a _data/books.json
  • I also think we need to add the route to our test suite.

I can make some additional issues with context for those.

Copy link
Contributor

@kjaymiller kjaymiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small fix to get tests running again.

@kjaymiller kjaymiller mentioned this pull request Sep 30, 2024
@kjaymiller
Copy link
Contributor

@Selasi3 can you add the things needed to make this compatible with #488.

the _data/books should have the one book that was read at this point.

[
{
  "title": "Boost Your Django DX",
  "author": "Adam Johnson",
  "url": "https://adamchainz.gumroad.com/l/byddx"
  "reviews": [
                       {
                          "title":  "Review: Boost Your Django DX by Adam Johnson",
                          "author": "Velda Kiara",
                          "url": "https://dev.to/veldakiara/review-boost-your-django-dx-by-adam-johnson-9ho"]
                       }
                    ]
}
]

@kjaymiller
Copy link
Contributor

@Selasi3 - if you run into any problems send the errors here and perhaps I can help you with them.

@Selasi3
Copy link
Contributor Author

Selasi3 commented Sep 30, 2024 via email

@kjaymiller kjaymiller self-requested a review September 30, 2024 21:16
@kjaymiller kjaymiller added the design_change triggers the generate_screenshot workflow label Sep 30, 2024
@kjaymiller kjaymiller merged commit 7bc8db1 into BlackPythonDevs:gh-pages Sep 30, 2024
3 checks passed
@Selasi3
Copy link
Contributor Author

Selasi3 commented Sep 30, 2024 via email

@kjaymiller
Copy link
Contributor

There are plenty of issues still out there. You did some work for the footer. You can jump on that.

Make sure that you create a test for that footer content.

@Selasi3
Copy link
Contributor Author

Selasi3 commented Sep 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design_change triggers the generate_screenshot workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants