Skip to content

Page additions #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2024
Merged

Page additions #502

merged 4 commits into from
Oct 5, 2024

Conversation

cmm25
Copy link
Contributor

@cmm25 cmm25 commented Oct 5, 2024

This pull request addresses two key areas:

  1. Comprehensive update to the MAINTAINERS.md file
  2. Resolution of Ruby version incompatibility

MAINTAINERS.md Update

The MAINTAINERS.md file has been extensively revised to enhance clarity and accessibility for new and experienced contributors. Key updates include:

  • Restructured content with a clear table of contents
  • Added a "Getting Started" section to guide newcomers
  • Provided detailed, step-by-step instructions for common tasks (e.g., accessibility testing, translations)
  • Expanded sections on styling and adding new pages
  • Simplified language while maintaining the depth of information
  • Emphasized open communication and seeking help when needed

These improvements aim to streamline the contribution process and make it more approachable for contributors at all levels.

Ruby Version Compatibility Fix

I encountered an error when trying to install Ruby 3.3.4:

rbenv: version `3.3.4' is not installed (set by /workspaces/blackpythondevs.github.io/.ruby-version)

To resolve this, the project has been updated to use Ruby 3.3.0, the latest available version in the rbenv list. The update includes:

  1. Modifying the .ruby-version file to specify version 3.3.0
  2. Adjusting the Gemfile for compatibility with Ruby 3.3.0
  3. Updating the Gemfile.lock to reflect necessary dependency changes

These updates should resolve installation issues and provide a smoother setup experience for future contributors.

@cmm25 cmm25 mentioned this pull request Oct 5, 2024
.ruby-version Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we keep having problems with ruby version changing with development based on who is doing the development.

TODO:

Either:
Create Issue to add .ruby-version and Gemfile.lock to gitignore
or
Set ruby_version and gemfile.lock and do not allow updates to .ruby_version or Gemfile.lock unless that is the issue.

@kjaymiller kjaymiller self-requested a review October 5, 2024 15:52
Copy link
Contributor

@kjaymiller kjaymiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can remove your ruby_version and gemfile.lock changes.

After that it's good to go!

@kjaymiller
Copy link
Contributor

@cmm25 see review. Only a minor issue and then we're all set to add.

@cmm25
Copy link
Contributor Author

cmm25 commented Oct 5, 2024

done check my lastest commit

@kjaymiller kjaymiller merged commit 469afd7 into BlackPythonDevs:gh-pages Oct 5, 2024
2 checks passed
@cmm25 cmm25 deleted the Page_additions branch October 5, 2024 17:07
@cmm25 cmm25 restored the Page_additions branch October 5, 2024 17:07
@kjaymiller kjaymiller linked an issue Oct 5, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Page additions
2 participants