Add steps for ensuring pre-commit hooks are installed #416
Conversation
Allows us to better debug why the tests just occasionally fail
I somehow missed that the command existed
Playwright has a built-in "slowmo" feature that would be easiest to use. https://playwright.dev/python/docs/test-runners#cli-arguments
The `to_equal` doesn't seem to exist in playwright for python. There is a NodeJS equivalent, but there is no supported GenericAssertion equivalent for python https://playwright.dev/docs/api/class-genericassertions
|
Okay lots of commits later (we should definitely do a squash and merge for this one), and it is finally ready for review! @kjaymiller |
README.md
Outdated
| Follow these steps and note these guidelines to begin contributing: | ||
|
|
||
| 1. First step is to set up the local development environment. | ||
| 1. Bug fixes are always welcome. Start by reviewing the [list of bugs](https://github.com/BlackPythonDevs/blackpythondevs.github.io/issues). |
There was a problem hiding this comment.
| 1. Bug fixes are always welcome. Start by reviewing the [list of bugs](https://github.com/BlackPythonDevs/blackpythondevs.github.io/issues). | |
| 2. Bug fixes are always welcome. Start by reviewing the [list of bugs](https://github.com/BlackPythonDevs/blackpythondevs.github.io/issues). |
README.md
Outdated
|
|
||
| 1. First step is to set up the local development environment. | ||
| 1. Bug fixes are always welcome. Start by reviewing the [list of bugs](https://github.com/BlackPythonDevs/blackpythondevs.github.io/issues). | ||
| 1. A good way to easily start contributing is to pick and work on a [good first issue](https://github.com/BlackPythonDevs/blackpythondevs.github.io/labels/good%20first%20issue). We try to make these issues as clear as possible and provide basic info on how the code should be changed, and if something is unclear feel free to ask for more information on the issue. |
There was a problem hiding this comment.
| 1. A good way to easily start contributing is to pick and work on a [good first issue](https://github.com/BlackPythonDevs/blackpythondevs.github.io/labels/good%20first%20issue). We try to make these issues as clear as possible and provide basic info on how the code should be changed, and if something is unclear feel free to ask for more information on the issue. | |
| 3. A good way to easily start contributing is to pick and work on a [good first issue](https://github.com/BlackPythonDevs/blackpythondevs.github.io/labels/good%20first%20issue). We try to make these issues as clear as possible and provide basic info on how the code should be changed, and if something is unclear feel free to ask for more information on the issue. |
README.md
Outdated
There was a problem hiding this comment.
Great work on breaking this information down. One thing I would like to do is move these steps into CONTRIBUTING.md.
There was a problem hiding this comment.
@dragid10 - should it take 30 minutes? I don't think I've seen it take that long ever
There was a problem hiding this comment.
I doubt it would, but as I was testing some changes on the GH actions, I found out that it has a very long (or no) timeout. So if something funky starts happening, then I'd like to kill the actions job in a reasonable amount of time
There was a problem hiding this comment.
I would consider like maybe 10 minutes then. I really don't imaging it getting much longer than that (of course until it does)
There was a problem hiding this comment.
but that can be added in a new issue. Great work on this one!
Added steps for running tests and pre-commit linters/formatters.
Additions:
Changes:
bundle execis greedy and steals the terminal from the user, we send it to the background so that the user can then run other commands easilyCloses #351