-
Notifications
You must be signed in to change notification settings - Fork 63
Add steps for ensuring pre-commit hooks are installed #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
e5fa18d
Add steps for ensuring pre-commit hooks are installed
dragid10 e24f6db
Add .idea folder to gitignore
dragid10 d8f16b8
Add steps for running tests and linters/formatters
dragid10 38cd5c0
Merge remote-tracking branch 'upstream/gh-pages' into gh-pages
dragid10 2108766
Retain trace logs on failure
dragid10 db952b3
Add tracing to playwright tests
dragid10 63d46d5
Run tracing action regardless of test status
dragid10 53bd37f
Fix folder where test results will upload
dragid10 bea0117
Use proper tests dir
dragid10 d6a5b28
Actually turn on tracing and upload the resulting failed results
dragid10 2d3870c
Use jekyll serve detach command
dragid10 5bf3807
Add macos, jetbranins and vscode to gitignore
dragid10 ad7f414
Remove sleep fixture
dragid10 d44ff4f
Use standard python comparison operator
dragid10 3605f87
Add explanation to test assertion
dragid10 90e624c
Fix linting issues
dragid10 07fc1ab
Merge pull request #1 from dragid10/fix-playwright-tests
dragid10 7222b89
Merge branch 'gh-pages' into gh-pages
dragid10 937529c
Pull upstream changes
dragid10 349509e
Use white theme for images
dragid10 bebee3a
Remake changes in CONTRIBUTING file
dragid10 3851a17
Remove unneeded test-results folder
dragid10 a02f0c7
Revert .gitignore
dragid10 3ad0efa
Revert to base readme
dragid10 1f1a87b
Merge branch 'upstream-gh-pages' into gh-pages
dragid10 a04d7c0
Use white theme to stay consistent
dragid10 6c25c62
Increase GH action job to 30 mins
dragid10 368e725
Run linter to fix linting errors
dragid10 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ on: | |
|
||
jobs: | ||
test: | ||
timeout-minutes: 30 | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dragid10 - should it take 30 minutes? I don't think I've seen it take that long ever
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt it would, but as I was testing some changes on the GH actions, I found out that it has a very long (or no) timeout. So if something funky starts happening, then I'd like to kill the actions job in a reasonable amount of time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider like maybe 10 minutes then. I really don't imaging it getting much longer than that (of course until it does)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but that can be added in a new issue. Great work on this one!