Add missing factory test for WGTFACQ_C in test_metrics_factory.py#1181
Open
Add missing factory test for WGTFACQ_C in test_metrics_factory.py#1181
Conversation
|
Hi there, this is jenkins continuous integration... |
1 similar comment
|
Hi there, this is jenkins continuous integration... |
…trics_factory.py - Add test_factory_wgtfacq_c to test_metrics_factory.py for WGTFACQ_C coverage - Remove test_compute_weight_factors.py (all tests now covered by factory tests) Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/c16da518-be23-48a9-ac02-71b17d5f861d Co-authored-by: jcanton <5622559+jcanton@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove duplication between test_compute_weight_factors and test_metrics_factory
Remove duplication between test_compute_weight_factors.py and test_metrics_factory.py
Mar 30, 2026
msimberg
reviewed
Apr 14, 2026
Keep unit tests alongside factory tests as per project convention. The new test_factory_wgtfacq_c in test_metrics_factory.py is retained. Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/55dca839-2064-48c4-a45b-0b98091f5cad Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>
Copilot
AI
changed the title
Remove duplication between test_compute_weight_factors.py and test_metrics_factory.py
Add missing factory test for WGTFACQ_C in test_metrics_factory.py
Apr 14, 2026
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
Contributor
|
cscs-ci run default |
Contributor
|
cscs-ci run distributed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_compute_weight_factors.pytested weight factor computations directly, with most already having factory equivalents intest_metrics_factory.py. The unit tests are kept as-is since they follow the same pattern used elsewhere and only integration (factory) tests run in CI.test_factory_wgtfacq_ctotest_metrics_factory.py— the only weight factor computation that lacked a factory-level testtest_compute_weight_factors.pyunchanged — unit tests remain alongside factory tests per project convention📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.