Skip to content

Conversation

tobias-tengler
Copy link
Member

No description provided.

@tobias-tengler tobias-tengler force-pushed the tte/hc-switch-initialization-default branch from b5c46bf to dbb611c Compare October 3, 2025 13:05
@github-actions github-actions bot added the 📚 documentation This issue is about working on our documentation. label Oct 3, 2025
@tobias-tengler tobias-tengler marked this pull request as ready for review October 3, 2025 15:02
@tobias-tengler tobias-tengler force-pushed the tte/hc-switch-initialization-default branch 2 times, most recently from 7f4c14c to f9272df Compare October 3, 2025 15:13
@tobias-tengler tobias-tengler marked this pull request as draft October 3, 2025 17:00
@tobias-tengler tobias-tengler force-pushed the tte/hc-switch-initialization-default branch 2 times, most recently from 04f689c to 08a5eb7 Compare October 9, 2025 15:56
@tobias-tengler tobias-tengler force-pushed the tte/hc-switch-initialization-default branch from 08a5eb7 to 1598439 Compare October 10, 2025 15:23
@tobias-tengler tobias-tengler marked this pull request as ready for review October 10, 2025 15:32
@Copilot Copilot AI review requested due to automatic review settings October 10, 2025 15:32
@tobias-tengler tobias-tengler merged commit dfb2fa2 into main Oct 10, 2025
110 checks passed
@tobias-tengler tobias-tengler deleted the tte/hc-switch-initialization-default branch October 10, 2025 15:32
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@884a0e9). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##             main   #8758   +/-   ##
======================================
  Coverage        ?       0           
======================================
  Files           ?       0           
  Lines           ?       0           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?       0           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements eager initialization of Hot Chocolate request executors by default. Previously, schema and request executor creation was lazy (deferred until first request), but now they are created during server startup to improve initial request performance and provide faster feedback on schema errors.

  • Makes request executor creation eager by default instead of lazy
  • Replaces InitializeOnStartup() API with new AddWarmupTask() API for better warmup task control
  • Updates documentation to reflect the new eager initialization behavior

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
website/src/docs/hotchocolate/v16/server/warmup.md Rewrites documentation to reflect eager initialization as default behavior
website/src/docs/hotchocolate/v16/migrating/migrate-from-15-to-16.md Adds migration guide for eager initialization changes
src/HotChocolate/Core/src/Types/SchemaOptions.cs Adds LazyInitialization property to control initialization behavior
src/HotChocolate/Core/src/Execution/RequestExecutorManager.cs Removes warmup-specific logic and simplifies executor creation
src/HotChocolate/Core/src/Execution.Abstractions/Execution/IRequestExecutorWarmupTask.cs Adds ApplyOnlyOnStartup property to warmup task interface
Multiple test files Updates tests to use new AddWarmupTask() API instead of InitializeOnStartup()
AspNetCore/Warmup files Refactors warmup service to support new eager initialization pattern

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


/// <summary>
/// Specifies that the <see cref="IRequestExecutor"/> should be constructed
/// laz
Copy link

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment appears to be cut off. 'laz' should be completed to 'lazily'.

Suggested change
/// laz
/// lazily

Copilot uses AI. Check for mistakes.

public bool PublishRootFieldPagesToPromiseCache { get; set; } = true;

/// <summary>
/// Gets or sets whether the should be initialized lazily.
Copy link

Copilot AI Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The summary is missing the subject that should be initialized lazily. It should specify what gets initialized (e.g., 'request executor' or 'schema').

Suggested change
/// Gets or sets whether the should be initialized lazily.
/// Gets or sets whether the schema and request executor should be initialized lazily.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 documentation This issue is about working on our documentation. 🌶️ hot chocolate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants