-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed Limits tool full rewrite/refactor; Render overlay refactor #991
Draft
kvakvs
wants to merge
27
commits into
CitiesSkylinesMods:master
Choose a base branch
from
kvakvs:u-speedlimits-tool
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP refactoring Rebase on master
… and off-tool info overlays
…ed out to new Highlight class
… for overlay readonly/hover coloring
…mph refreshes window; Show alternate units below
…d correctly with helper graphics
…ng in SpeedLimits
kvakvs
force-pushed
the
u-speedlimits-tool
branch
from
November 15, 2020 01:29
3c7dedb
to
14711de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Speed Limits UI
NOTE: SVG source for two types of Road Signs are text (XML) files, taking a few thousands of lines, contributing to a huge added lines count. And deleted lines are rather moved, not actually deleted, contributing to both added and removed counts.
U User Interface
Speed Limits & UI Changes
float?
anymore, and there are enumerated types explicitly saying if its not set, or set to unlimited.Other TODO
Also
Fixes #988