Skip to content

Fix local server start help quotes - #482

Closed
sdairs wants to merge 1 commit into
issue-447-live-postgres-clickpipe-clifrom
issue-476-start-help-quotes
Closed

Fix local server start help quotes#482
sdairs wants to merge 1 commit into
issue-447-live-postgres-clickpipe-clifrom
issue-476-start-help-quotes

Conversation

@sdairs

@sdairs sdairs commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • render normal quotes around the default local server name in local server start --help
  • add a rendered-help regression test for the exact argument line and absence of escaped quotes

Closes #476

Verification

  • cargo test -p clickhousectl server_start_help_renders_default_name_quotes_without_escaping (1 passed)
  • cargo test -p clickhousectl local::cli::tests:: (20 passed)
  • cargo fmt --all --check
  • cargo clippy -p clickhousectl --all-targets -- -D warnings

@sdairs
sdairs force-pushed the issue-476-start-help-quotes branch from d905b64 to 32fb4c2 Compare August 25, 2026 12:11
@sdairs
sdairs changed the base branch from main to issue-447-live-postgres-clickpipe-cli August 25, 2026 12:13

@iskakaushik iskakaushik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdairs
sdairs force-pushed the issue-447-live-postgres-clickpipe-cli branch from 58d9124 to 41a0cc9 Compare August 25, 2026 22:01
@sdairs
sdairs force-pushed the issue-476-start-help-quotes branch from 32fb4c2 to 2876420 Compare August 25, 2026 22:01
@sdairs

sdairs commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #560 in stack #563.

@sdairs sdairs closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix escaped quotes in local server start help rendering

2 participants