Skip to content

Fix escaped quotes in local server start help - #560

Merged
sdairs merged 1 commit into
stack/477-server-project-scope-errorsfrom
stack/476-fix-start-help-quotes
Aug 27, 2026
Merged

Fix escaped quotes in local server start help#560
sdairs merged 1 commit into
stack/477-server-project-scope-errorsfrom
stack/476-fix-start-help-quotes

Conversation

@sdairs

@sdairs sdairs commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • render normal quotes around default in local server start --help
  • pin the exact argument help line and reject escaped quote rendering

Tests

  • cargo test -p clickhousectl server_start_help_renders_default_name_without_escaped_quotes
  • cargo test -p clickhousectl local::cli::tests
  • cargo fmt --all --check
  • cargo clippy -p clickhousectl --all-targets -- -D warnings

Closes #476

@sdairs

sdairs commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

Carry-over review from PR #482 (old PR for #476). Functionally identical one-line fix; this PR's test is marginally stronger (asserts ErrorKind::DisplayHelp and matches the help line exactly rather than contains). No sdairs review comments existed on #482 (only an external LGTM). No changes required.

One note: local postgres edge cases fails on this branch, but the identical failure exists on its base branch — inherited from the stack base (#547 script drift), not from this diff which touches only a help string and a unit test. Should go green once #547's script update lands and the stack rebases.

@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch 2 times, most recently from ac89cc5 to b95b1e6 Compare August 26, 2026 19:01
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from b95b1e6 to c204c6b Compare August 26, 2026 19:03
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from c204c6b to 5c7e336 Compare August 26, 2026 19:07
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from 5c7e336 to 5f009bf Compare August 26, 2026 19:10
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch 3 times, most recently from c7aafb3 to fd4e9de Compare August 26, 2026 19:24
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch 2 times, most recently from e1d9fdd to a0cda51 Compare August 26, 2026 19:31
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from a0cda51 to aac4b44 Compare August 26, 2026 19:34
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from aac4b44 to 710ebae Compare August 26, 2026 19:36
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from 710ebae to 18f1340 Compare August 26, 2026 20:10
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from 18f1340 to 50a3297 Compare August 26, 2026 20:30
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from 50a3297 to a73dd96 Compare August 26, 2026 20:35
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from c423eed to c40b295 Compare August 27, 2026 06:34
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from c40b295 to a06ba7f Compare August 27, 2026 06:44
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from a06ba7f to 8617742 Compare August 27, 2026 06:49
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch 2 times, most recently from 75dc957 to 9a7b47e Compare August 27, 2026 06:57
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch 2 times, most recently from 92f9c07 to c6b5919 Compare August 27, 2026 07:12
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch 2 times, most recently from 8b4adfa to f571fd5 Compare August 27, 2026 07:24
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from f571fd5 to ea55174 Compare August 27, 2026 07:32
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from ea55174 to 18c656b Compare August 27, 2026 07:37
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch 2 times, most recently from 8c85546 to d214b19 Compare August 27, 2026 10:13
@sdairs
sdairs force-pushed the stack/476-fix-start-help-quotes branch from d214b19 to 38e0072 Compare August 27, 2026 10:51
@sdairs
sdairs merged commit 4211ece into main Aug 27, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix escaped quotes in local server start help rendering

2 participants