Fix escaped quotes in local server start help - #560
Merged
sdairs merged 1 commit intoAug 27, 2026
Merged
Conversation
Collaborator
Author
|
Carry-over review from PR #482 (old PR for #476). Functionally identical one-line fix; this PR's test is marginally stronger (asserts One note: |
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
2 times, most recently
from
August 26, 2026 19:01
ac89cc5 to
b95b1e6
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 26, 2026 19:03
b95b1e6 to
c204c6b
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 26, 2026 19:07
c204c6b to
5c7e336
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 26, 2026 19:10
5c7e336 to
5f009bf
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
3 times, most recently
from
August 26, 2026 19:24
c7aafb3 to
fd4e9de
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
2 times, most recently
from
August 26, 2026 19:31
e1d9fdd to
a0cda51
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 26, 2026 19:34
a0cda51 to
aac4b44
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 26, 2026 19:36
aac4b44 to
710ebae
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 26, 2026 20:10
710ebae to
18f1340
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 26, 2026 20:30
18f1340 to
50a3297
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 26, 2026 20:35
50a3297 to
a73dd96
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 27, 2026 06:34
c423eed to
c40b295
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 27, 2026 06:44
c40b295 to
a06ba7f
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 27, 2026 06:49
a06ba7f to
8617742
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
2 times, most recently
from
August 27, 2026 06:57
75dc957 to
9a7b47e
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
2 times, most recently
from
August 27, 2026 07:12
92f9c07 to
c6b5919
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
2 times, most recently
from
August 27, 2026 07:24
8b4adfa to
f571fd5
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 27, 2026 07:32
f571fd5 to
ea55174
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 27, 2026 07:37
ea55174 to
18c656b
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
2 times, most recently
from
August 27, 2026 10:13
8c85546 to
d214b19
Compare
sdairs
force-pushed
the
stack/476-fix-start-help-quotes
branch
from
August 27, 2026 10:51
d214b19 to
38e0072
Compare
iskakaushik
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultinlocal server start --helpTests
cargo test -p clickhousectl server_start_help_renders_default_name_without_escaped_quotescargo test -p clickhousectl local::cli::testscargo fmt --all --checkcargo clippy -p clickhousectl --all-targets -- -D warningsCloses #476