Skip to content

Validate local ClickHouse version operands during CLI parsing - #485

Closed
sdairs wants to merge 4 commits into
issue-470-local-client-query-multiplicityfrom
issue-463-parse-version-operands
Closed

Validate local ClickHouse version operands during CLI parsing#485
sdairs wants to merge 4 commits into
issue-470-local-client-query-multiplicityfrom
issue-463-parse-version-operands

Conversation

@sdairs

@sdairs sdairs commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Parse install, use, and server ClickHouse version operands through clap before dispatch.
  • Preserve install-only postgres@<tag> and postgres:<tag> forms while leaving remove and local Postgres selectors unchanged.
  • Report malformed and unsupported three-part versions as clap exit 2 with invalid_value telemetry and no operand leakage.

Tests

  • cargo test -p clickhousectl local::cli::tests (26 passed)
  • cargo test -p clickhousectl --test local_version_error_test (1 passed)
  • cargo test -p clickhousectl --test telemetry_test invalid_local_versions_report_invalid_value_without_leaking_operands (1 passed)
  • cargo test -p clickhousectl (745 passed)
  • cargo test -p clickhousectl --no-default-features (674 passed)
  • cargo fmt --all --check
  • cargo clippy -p clickhousectl --all-targets -- -D warnings

Stack

  • Position: 1 of 1
  • Base: main

Closes #463

Stack created with GitHub Stacks CLIGive Feedback

@sdairs sdairs changed the title issue 463 parse version operands Validate local ClickHouse version operands during CLI parsing Aug 24, 2026
@sdairs
sdairs force-pushed the issue-463-parse-version-operands branch from d5f4a92 to cb4ce84 Compare August 25, 2026 12:11
@sdairs
sdairs changed the base branch from main to issue-470-local-client-query-multiplicity August 25, 2026 12:13

@iskakaushik iskakaushik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdairs

sdairs commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #542 in stack #563.

@sdairs sdairs closed this Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate local ClickHouse version operands during CLI parsing

2 participants