Validate local ClickHouse version operands during CLI parsing - #485
Closed
sdairs wants to merge 4 commits into
Closed
Validate local ClickHouse version operands during CLI parsing#485sdairs wants to merge 4 commits into
sdairs wants to merge 4 commits into
Conversation
sdairs
force-pushed
the
issue-463-parse-version-operands
branch
from
August 25, 2026 12:11
d5f4a92 to
cb4ce84
Compare
sdairs
changed the base branch from
main
to
issue-470-local-client-query-multiplicity
August 25, 2026 12:13
Collaborator
Author
|
Superseded by #542 in stack #563. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postgres@<tag>andpostgres:<tag>forms while leaving remove and local Postgres selectors unchanged.invalid_valuetelemetry and no operand leakage.Tests
cargo test -p clickhousectl local::cli::tests(26 passed)cargo test -p clickhousectl --test local_version_error_test(1 passed)cargo test -p clickhousectl --test telemetry_test invalid_local_versions_report_invalid_value_without_leaking_operands(1 passed)cargo test -p clickhousectl(745 passed)cargo test -p clickhousectl --no-default-features(674 passed)cargo fmt --all --checkcargo clippy -p clickhousectl --all-targets -- -D warningsStack
mainCloses #463
Stack created with GitHub Stacks CLI • Give Feedback