Validate local ClickHouse versions during CLI parsing - #542
Conversation
|
Carry-over review from PR #485 (old PR for #463). This PR is a strict improvement over #485 (per-command types
Cosmetic: leading-whitespace |
5cebc44 to
9e8c38c
Compare
9e8c38c to
31cc998
Compare
31cc998 to
1eaaa40
Compare
01d7e4f to
1628f33
Compare
1628f33 to
0180a57
Compare
a10467e to
ab7f46b
Compare
ab7f46b to
5d6e3d0
Compare
b6b077e to
561b611
Compare
ffd020c to
e569e55
Compare
Summary
Design notes
local remove <version>intentionally remains an opaque string because removal matches exact installed directory names rather than resolving version syntaxUseVersionArgandServerVersionArgintentionally remain separate so each command owns its accepted inputs and diagnosticsTests
cargo test -p clickhousectlcargo test -p clickhousectl local::cli::testscargo test -p clickhousectl --test local_version_error_testcargo test -p clickhousectl --test telemetry_test invalid_local_versions_report_invalid_value_without_dispatch_side_effectscargo check -p clickhousectl --no-default-featurescargo fmt --all --checkcargo clippy -p clickhousectl --all-targets -- -D warningsCloses #463