Skip to content

quick dirty fix for 0 armor error logging#4526

Open
SaltyKarl wants to merge 4 commits intoCombatExtended-Continued:Developmentfrom
SaltyKarl:skip-logging-0armor-on-stuff
Open

quick dirty fix for 0 armor error logging#4526
SaltyKarl wants to merge 4 commits intoCombatExtended-Continued:Developmentfrom
SaltyKarl:skip-logging-0armor-on-stuff

Conversation

@SaltyKarl
Copy link
Contributor

@SaltyKarl SaltyKarl commented Mar 25, 2026

Additions

the log only happens when the armor in question is not a headset nor backpack or tac vest

Changes

2 checks added

References

bug chat

Reasoning

because headsets and backpack and tac vest all have something unique

Alternatives

xml patch all the armor that can cause the error, or a flag in xml which is like this pr's check but more work

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@SaltyKarl SaltyKarl requested review from a team as code owners March 25, 2026 16:51
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23553175166.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Mar 25, 2026
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23554330452.zip

@Safairette
Copy link
Contributor

The isBackpack and isWebbing flags are both temporary and meant for the use with the rendering toggle in settings, so will likely not apply to all webbings/backpacks or may be applied to other apparel categories.

So I'd recommend not using those here.

@SaltyKarl
Copy link
Contributor Author

The isBackpack and isWebbing flags are both temporary and meant for the use with the rendering toggle in settings, so will likely not apply to all webbings/backpacks or may be applied to other apparel categories.

So I'd recommend not using those here.

I see, I'll switch those two checks to work off layers as well

@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23645912929.zip

@SaltyKarl SaltyKarl force-pushed the skip-logging-0armor-on-stuff branch from 6addf6f to 58ec0e4 Compare March 27, 2026 12:22
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23645987582.zip

@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23646068779.zip

@SaltyKarl SaltyKarl force-pushed the skip-logging-0armor-on-stuff branch from de2390b to 761b932 Compare March 27, 2026 12:26
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-23646142071.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Download in Comments This PR has a zipfile download available.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants