[soobing] WEEK01 Solution #1675
Open
+206
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hu6r1s
reviewed
Jul 24, 2025
Comment on lines
+33
to
+40
| const dp = (i: number) => { | ||
| if (i < 0) return 0; | ||
| if (memo.has(i)) return memo.get(i); | ||
|
|
||
| const res = Math.max(dp(i - 1)!, dp(i - 2)! + nums[i]); | ||
| memo.set(i, res); | ||
| return res; | ||
| }; |
There was a problem hiding this comment.
현재 ! 연산자를 사용해도 코딩 테스트에선 문제는 없지만, 혹시 dp 함수의 반환 타입을 명시적으로 number로 지정해보는 건 어떨까요? const dp = (i: number): number => {
그렇게 하면 non-null assertion 없이도 컴파일러가 타입을 안전하게 추론해줘서 더 명확해질 것 같아요!!😊
Comment on lines
+37
to
+40
| if (this.heap.length === 0) return undefined; | ||
| const min = this.heap[0]; | ||
| const end = this.heap.pop(); | ||
| if (this.heap.length > 0 && end !== undefined) { |
There was a problem hiding this comment.
if (this.heap.length === 0) return undefined;로 힙에 값이 없으면 undefined를 반환하도록 되어 있으니 end !== undefined는 없어도 되지 않을까요?
| * 공간 복잡도: O(N) | ||
| */ | ||
| class MinHeap { | ||
| heap: [number, number][] = []; |
There was a problem hiding this comment.
[number, number][] 이 형식이 뭔지 궁금합니다!
hu6r1s
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!