comp/core/agenttelemetry: preserve remote_agent tag for dogstatsd bytes metrics in COAT

[jszwedko]

Summary

ADP registers as a remote agent and emits dogstatsd.udp_packets_bytes and dogstatsd.uds_packets_bytes tagged with remote_agent=<display_name> via the Remote Agent Registry. Without aggregate_tags, COAT strips all tags and makes these metrics indistinguishable from the core agent's own dogstatsd metrics. This adds aggregate_tags: [remote_agent] to those two metrics in the default COAT profile, and adds remote_agent=agent as a static label to both counters in the dogstatsd listeners (following the same pattern as logs.encoded_bytes_sent) so that COAT's aggregate_tags filter finds the tag present on core Agent timeseries rather than dropping them.

Test plan

• dda inv test --targets=./comp/core/agenttelemetry/... — passes
• Verify COAT dashboard shows remote_agent dimension on dogstatsd.udp_packets_bytes / dogstatsd.uds_packets_bytes after ADP is deployed with a real APP_FULL_NAME build var

🤖 Generated with Claude Code

[datadog-prod-us1-3]

🎯 Code Coverage (details)
• Patch Coverage: 80.00%
• Overall Coverage: 50.26% (-0.01%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cca62e7 | Docs | Datadog PR Page | Give us feedback!}

[dd-octo-sts]

Files inventory check summary

File checks results against ancestor ed51e26c:

Results for datadog-agent_7.80.0~devel.git.515.cca62e7.pipeline.111738689-1_amd64.deb:

No change detected

[dd-octo-sts]

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor ed51e26
📊 Static Quality Gates Dashboard
🔗 SQG Job

Successful checks

Info

	Quality gate	Change	Size (prev → curr → max)
✅	agent_deb_amd64_fips	+4.34 KiB (0.00% increase)	700.315 → 700.320 → 702.690
✅	agent_rpm_amd64_fips	+4.34 KiB (0.00% increase)	700.299 → 700.303 → 702.670
✅	agent_suse_amd64_fips	+4.34 KiB (0.00% increase)	700.299 → 700.303 → 702.670

29 successful checks with minimal change (< 2 KiB)

	Quality gate	Current Size
✅	agent_deb_amd64	742.253 MiB
✅	agent_heroku_amd64	309.178 MiB
✅	agent_rpm_amd64	742.237 MiB
✅	agent_rpm_arm64	720.159 MiB
✅	agent_rpm_arm64_fips	681.324 MiB
✅	agent_suse_amd64	742.237 MiB
✅	agent_suse_arm64	720.159 MiB
✅	agent_suse_arm64_fips	681.324 MiB
✅	docker_agent_amd64	802.491 MiB
✅	docker_agent_arm64	805.258 MiB
✅	docker_agent_jmx_amd64	993.411 MiB
✅	docker_agent_jmx_arm64	984.956 MiB
✅	docker_cluster_agent_amd64	206.607 MiB
✅	docker_cluster_agent_arm64	220.634 MiB
✅	docker_cws_instrumentation_amd64	7.142 MiB
✅	docker_cws_instrumentation_arm64	6.689 MiB
✅	docker_host_profiler_amd64	301.580 MiB
✅	docker_host_profiler_arm64	313.059 MiB
✅	docker_dogstatsd_amd64	39.496 MiB
✅	docker_dogstatsd_arm64	37.690 MiB
✅	dogstatsd_deb_amd64	30.149 MiB
✅	dogstatsd_deb_arm64	28.279 MiB
✅	dogstatsd_rpm_amd64	30.149 MiB
✅	dogstatsd_suse_amd64	30.149 MiB
✅	iot_agent_deb_amd64	44.462 MiB
✅	iot_agent_deb_arm64	41.442 MiB
✅	iot_agent_deb_armhf	42.183 MiB
✅	iot_agent_rpm_amd64	44.462 MiB
✅	iot_agent_suse_amd64	44.462 MiB

[cit-pr-commenter-54b7da]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d1d908ce-094e-4c0f-8c46-0c7c5e6c5f8a

Baseline: 616af2f
Comparison: 74ce90f
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+4.13	[+1.21, +7.06]	1	Logs

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	docker_containers_cpu	% cpu utilization	+4.13	[+1.21, +7.06]	1	Logs
➖	ddot_metrics_sum_cumulativetodelta_exporter	memory utilization	+0.92	[+0.68, +1.17]	1	Logs
➖	ddot_metrics_sum_delta	memory utilization	+0.63	[+0.45, +0.82]	1	Logs
➖	quality_gate_security_no_fs_load	memory utilization	+0.46	[+0.35, +0.56]	1	Logs bounds checks dashboard
➖	quality_gate_metrics_logs	memory utilization	+0.44	[+0.19, +0.69]	1	Logs bounds checks dashboard
➖	quality_gate_idle	memory utilization	+0.40	[+0.35, +0.44]	1	Logs bounds checks dashboard
➖	otlp_ingest_metrics	memory utilization	+0.37	[+0.22, +0.53]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.07	[-0.08, +0.22]	1	Logs
➖	ddot_logs	memory utilization	+0.06	[-0.01, +0.13]	1	Logs
➖	uds_dogstatsd_to_api_v3	ingress throughput	+0.00	[-0.20, +0.21]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.01	[-0.40, +0.39]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.01	[-0.13, +0.10]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.03	[-0.23, +0.18]	1	Logs
➖	uds_dogstatsd_20mb_12k_contexts_20_senders	memory utilization	-0.04	[-0.09, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.04	[-0.54, +0.46]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.06	[-0.50, +0.37]	1	Logs
➖	ddot_metrics	memory utilization	-0.12	[-0.31, +0.08]	1	Logs
➖	docker_containers_memory	memory utilization	-0.12	[-0.22, -0.01]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-0.39	[-0.44, -0.35]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-0.42	[-0.63, -0.22]	1	Logs
➖	quality_gate_security_idle	memory utilization	-0.44	[-0.51, -0.37]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	-0.44	[-1.41, +0.52]	1	Logs bounds checks dashboard
➖	quality_gate_security_mean_fs_load	memory utilization	-0.46	[-0.50, -0.42]	1	Logs bounds checks dashboard
➖	otlp_ingest_logs	memory utilization	-0.60	[-0.70, -0.50]	1	Logs
➖	ddot_metrics_sum_cumulative	memory utilization	-0.86	[-1.01, -0.70]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	observed_value	links
✅	docker_containers_cpu	simple_check_run	10/10	589 ≥ 26
✅	docker_containers_memory	memory_usage	10/10	245.17MiB ≤ 370MiB
✅	docker_containers_memory	simple_check_run	10/10	697 ≥ 26
✅	file_to_blackhole_0ms_latency	memory_usage	10/10	0.16GiB ≤ 1.20GiB
✅	file_to_blackhole_0ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10	0.20GiB ≤ 1.20GiB
✅	file_to_blackhole_1000ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_100ms_latency	memory_usage	10/10	0.17GiB ≤ 1.20GiB
✅	file_to_blackhole_100ms_latency	missed_bytes	10/10	0B = 0B
✅	file_to_blackhole_500ms_latency	memory_usage	10/10	0.18GiB ≤ 1.20GiB
✅	file_to_blackhole_500ms_latency	missed_bytes	10/10	0B = 0B
✅	quality_gate_idle	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	141.01MiB ≤ 147MiB	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	3 ≤ 4	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	468.48MiB ≤ 495MiB	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10	3 ≤ 6	bounds checks dashboard
✅	quality_gate_logs	memory_usage	10/10	174.71MiB ≤ 195MiB	bounds checks dashboard
✅	quality_gate_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_metrics_logs	cpu_usage	10/10	359.49 ≤ 2000	bounds checks dashboard
✅	quality_gate_metrics_logs	intake_connections	10/10	4 ≤ 6	bounds checks dashboard
✅	quality_gate_metrics_logs	memory_usage	10/10	389.35MiB ≤ 430MiB	bounds checks dashboard
✅	quality_gate_metrics_logs	missed_bytes	10/10	0B = 0B	bounds checks dashboard
✅	quality_gate_security_idle	cpu_usage	10/10	23.81 ≤ 40	bounds checks dashboard
✅	quality_gate_security_idle	memory_usage	10/10	288.39MiB ≤ 330MiB	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	cpu_usage	10/10	53.95 ≤ 70	bounds checks dashboard
✅	quality_gate_security_mean_fs_load	memory_usage	10/10	265.86MiB ≤ 320MiB	bounds checks dashboard
✅	quality_gate_security_no_fs_load	cpu_usage	10/10	20.19 ≤ 40	bounds checks dashboard
✅	quality_gate_security_no_fs_load	memory_usage	10/10	277.51MiB ≤ 320MiB	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_security_no_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_no_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_mean_fs_load, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_security_idle, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
• quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebf41c0883

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[jszwedko]

I tested this out locally and observed that the telemetry, when the Agent was publishing it, ended up with remote_agent=agent and, when ADP was, remote_agent=agent-data-plane.