Skip to content

comp/core/agenttelemetry: preserve remote_agent tag for dogstatsd bytes metrics in COAT #50386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 4 commits into from
May 6, 2026
Merged

comp/core/agenttelemetry: preserve remote_agent tag for dogstatsd bytes metrics in COAT #50386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebf41c0
comp/core/agenttelemetry: preserve remote_agent tag for dogstatsd byt…
jszwedko May 5, 2026
fe74bdd
comp/dogstatsd/listeners: add remote_agent label to UDP/UDS bytes cou…
jszwedko May 5, 2026
a56fbac
comp/dogstatsd/listeners: inline remote_agent value, remove unused id…
jszwedko May 5, 2026
cca62e7
Merge branch 'main' into jszwedko/dogstatsd-remote-agent-tag
jszwedko May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions comp/core/agenttelemetry/impl/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,11 @@ var defaultProfiles = `
zero_metric: true
metrics:
- name: dogstatsd.udp_packets_bytes
aggregate_tags:
- remote_agent
- name: dogstatsd.uds_packets_bytes
aggregate_tags:
- remote_agent
Comment thread
jszwedko marked this conversation as resolved.
- name: logs.bytes_missed
- name: logs.bytes_sent
aggregate_tags:
Expand Down
4 changes: 2 additions & 2 deletions comp/dogstatsd/listeners/telemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ func NewTelemetryStore(buckets []float64, telemetrycomp telemetry.Component) *Te
tlmUDPPackets: telemetrycomp.NewCounter("dogstatsd", "udp_packets",
[]string{"state"}, "Dogstatsd UDP packets count"),
tlmUDPPacketsBytes: telemetrycomp.NewCounter("dogstatsd", "udp_packets_bytes",
nil, "Dogstatsd UDP packets bytes count"),
[]string{"remote_agent"}, "Dogstatsd UDP packets bytes count"),
tlmUDSPackets: telemetrycomp.NewCounter("dogstatsd", "uds_packets",
[]string{"listener_id", "transport", "state"}, "Dogstatsd UDS packets count"),
tlmUDSOriginDetectionError: telemetrycomp.NewCounter("dogstatsd", "uds_origin_detection_error",
[]string{"listener_id", "transport"}, "Dogstatsd UDS origin detection error count"),
tlmUDSPacketsBytes: telemetrycomp.NewCounter("dogstatsd", "uds_packets_bytes",
[]string{"listener_id", "transport"}, "Dogstatsd UDS packets bytes"),
[]string{"remote_agent", "listener_id", "transport"}, "Dogstatsd UDS packets bytes"),
tlmUDSConnections: telemetrycomp.NewGauge("dogstatsd", "uds_connections",
[]string{"listener_id", "transport"}, "Dogstatsd UDS connections count"),
tlmListener: telemetrycomp.NewHistogram(
Expand Down
2 changes: 1 addition & 1 deletion comp/dogstatsd/listeners/udp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func (l *UDPListener) listen() {
l.telemetryStore.tlmUDPPackets.Inc("ok")

udpBytes.Add(int64(n))
l.telemetryStore.tlmUDPPacketsBytes.Add(float64(n))
l.telemetryStore.tlmUDPPacketsBytes.Add(float64(n), "agent")

// packetAssembler merges multiple packets together and sends them when its buffer is full
l.packetAssembler.AddMessage(l.buffer[:n])
Expand Down
4 changes: 2 additions & 2 deletions comp/dogstatsd/listeners/uds_common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ func (l *UDSListener) handleConnection(conn netUnixConn, closeFunc CloseFunction
l.telemetryStore.tlmUDSPackets.Inc(tlmListenerID, l.transport, "ok")

udsBytes.Add(int64(n))
l.telemetryStore.tlmUDSPacketsBytes.Add(float64(n), tlmListenerID, l.transport)
l.telemetryStore.tlmUDSPacketsBytes.Add(float64(n), "agent", tlmListenerID, l.transport)
packet.Contents = packet.Buffer[:n]
packet.Source = packets.UDS
packet.ListenerID = listenerID
Expand Down Expand Up @@ -421,5 +421,5 @@ func (l *UDSListener) clearTelemetry(id string) {
l.telemetryStore.tlmUDSConnections.Delete(id, l.transport)
l.telemetryStore.tlmUDSPackets.Delete(id, l.transport, "error")
l.telemetryStore.tlmUDSPackets.Delete(id, l.transport, "ok")
l.telemetryStore.tlmUDSPacketsBytes.Delete(id, l.transport)
l.telemetryStore.tlmUDSPacketsBytes.Delete("agent", id, l.transport)
}
Loading