Remove the warning on kotlin plugin warning #9711
Merged
+818
−669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build scripts use the `buildscript` way to configure the project's plugins, which is not recommended anymore since quite a few versions in gradle.
```
The Kotlin Gradle plugin was loaded multiple times in different subprojects, which is not supported and may break the build.
This might happen in subprojects that apply the Kotlin plugins with the Gradle 'plugins { ... }' DSL if they specify explicit versions, even if the versions are equal.
Please add the Kotlin plugin to the common parent project or the root project, then remove the versions in the subprojects.
If the parent project does not need the plugin, add 'apply false' to the plugin line.
See: https://docs.gradle.org/current/userguide/plugins.html#sec:subprojects_plugins_dsl
The Kotlin plugin was loaded in the following projects: ':dd-java-agent:agent-ci-visibility', ':dd-java-agent:agent-llmobs'
```
bric3
added
tag: no release notes
bric3
requested review from
daniel-mohedano,
manuel-alvarez-alvarez and
sarahchen6
and removed request for
a team
bric3
commented
Oct 9, 2025
|
|
||
| project.tasks.matching { | ||
| it.name in ['compileJava', 'compileScala', 'compileKotlin', 'compileGroovy'] || | ||
| it.name in ['compileJava', 'compileScala', 'compileGroovy'] || |
There was a problem hiding this comment.
No instrumentation is written in Kotlin, and as such there no post-processing involved.
Comment on lines
-3
to
-11
| buildscript { | ||
| repositories { | ||
| mavenCentral() | ||
| } | ||
|
|
||
| dependencies { | ||
| classpath group: 'org.jetbrains.kotlin', name: 'kotlin-gradle-plugin', version: libs.versions.kotlin.get() | ||
| } | ||
| } |
There was a problem hiding this comment.
Also, this buildscript was not configured to use our maven proxy
|
|
||
| /** | ||
| * This controller creates an `Action` to handle HTTP requests to the | ||
| /** This controller creates an `Action` to handle HTTP requests to the |
There was a problem hiding this comment.
Note can ignore the *.scala files as they were just formatted. Side-effect of fixing the way the spotless plugin is configured. Before these files were not seen.
bric3
force-pushed
the
bdu/kotlin-plugin-warning
branch
from
4f5e9a1 to
16aecb0
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~16aecb0648, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1019933
Total [baseline] (8.671 s) : 0, 8670894
Agent [candidate] (1.016 s) : 0, 1015757
Total [candidate] (8.649 s) : 0, 8649324
section iast
Agent [baseline] (1.151 s) : 0, 1150651
Total [baseline] (9.246 s) : 0, 9246199
Agent [candidate] (1.15 s) : 0, 1149931
Total [candidate] (9.287 s) : 0, 9286506
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~16aecb0648, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (697.096 ms) : 0, 697096
BytebuddyAgent [candidate] (693.376 ms) : 0, 693376
GlobalTracer [baseline] (241.395 ms) : 0, 241395
GlobalTracer [candidate] (241.693 ms) : 0, 241693
AppSec [baseline] (32.288 ms) : 0, 32288
AppSec [candidate] (33.068 ms) : 0, 33068
Debugger [baseline] (6.393 ms) : 0, 6393
Debugger [candidate] (6.442 ms) : 0, 6442
Remote Config [baseline] (700.601 µs) : 0, 701
Remote Config [candidate] (696.059 µs) : 0, 696
Telemetry [baseline] (9.325 ms) : 0, 9325
Telemetry [candidate] (9.315 ms) : 0, 9315
Flare Poller [baseline] (10.127 ms) : 0, 10127
Flare Poller [candidate] (8.667 ms) : 0, 8667
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (815.011 ms) : 0, 815011
BytebuddyAgent [candidate] (814.206 ms) : 0, 814206
GlobalTracer [baseline] (231.605 ms) : 0, 231605
GlobalTracer [candidate] (231.368 ms) : 0, 231368
IAST [baseline] (26.478 ms) : 0, 26478
IAST [candidate] (26.531 ms) : 0, 26531
AppSec [baseline] (35.336 ms) : 0, 35336
AppSec [candidate] (35.453 ms) : 0, 35453
Debugger [baseline] (6.057 ms) : 0, 6057
Debugger [candidate] (6.15 ms) : 0, 6150
Remote Config [baseline] (606.415 µs) : 0, 606
Remote Config [candidate] (618.702 µs) : 0, 619
Telemetry [baseline] (8.538 ms) : 0, 8538
Telemetry [candidate] (8.692 ms) : 0, 8692
Flare Poller [baseline] (4.273 ms) : 0, 4273
Flare Poller [candidate] (4.219 ms) : 0, 4219
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~16aecb0648, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1013845
Total [baseline] (10.64 s) : 0, 10639885
Agent [candidate] (1.016 s) : 0, 1016305
Total [candidate] (10.775 s) : 0, 10775235
section appsec
Agent [baseline] (1.195 s) : 0, 1194609
Total [baseline] (11.013 s) : 0, 11013409
Agent [candidate] (1.193 s) : 0, 1192535
Total [candidate] (11.043 s) : 0, 11043463
section iast
Agent [baseline] (1.149 s) : 0, 1148538
Total [baseline] (11.015 s) : 0, 11015036
Agent [candidate] (1.149 s) : 0, 1148581
Total [candidate] (11.052 s) : 0, 11051659
section profiling
Agent [baseline] (1.158 s) : 0, 1158184
Total [baseline] (11.011 s) : 0, 11010677
Agent [candidate] (1.168 s) : 0, 1167728
Total [candidate] (11.044 s) : 0, 11043688
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~16aecb0648, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (692.103 ms) : 0, 692103
BytebuddyAgent [candidate] (692.367 ms) : 0, 692367
GlobalTracer [baseline] (241.06 ms) : 0, 241060
GlobalTracer [candidate] (241.167 ms) : 0, 241167
AppSec [baseline] (32.334 ms) : 0, 32334
AppSec [candidate] (32.881 ms) : 0, 32881
Debugger [baseline] (6.373 ms) : 0, 6373
Debugger [candidate] (6.379 ms) : 0, 6379
Remote Config [baseline] (693.264 µs) : 0, 693
Remote Config [candidate] (694.997 µs) : 0, 695
Telemetry [baseline] (9.342 ms) : 0, 9342
Telemetry [candidate] (9.229 ms) : 0, 9229
Flare Poller [baseline] (9.368 ms) : 0, 9368
Flare Poller [candidate] (11.013 ms) : 0, 11013
section appsec
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (718.744 ms) : 0, 718744
BytebuddyAgent [candidate] (716.115 ms) : 0, 716115
GlobalTracer [baseline] (234.505 ms) : 0, 234505
GlobalTracer [candidate] (233.962 ms) : 0, 233962
AppSec [baseline] (174.892 ms) : 0, 174892
AppSec [candidate] (175.645 ms) : 0, 175645
Debugger [baseline] (6.134 ms) : 0, 6134
Debugger [candidate] (6.147 ms) : 0, 6147
Remote Config [baseline] (636.43 µs) : 0, 636
Remote Config [candidate] (644.738 µs) : 0, 645
Telemetry [baseline] (8.387 ms) : 0, 8387
Telemetry [candidate] (8.548 ms) : 0, 8548
Flare Poller [baseline] (3.896 ms) : 0, 3896
Flare Poller [candidate] (3.985 ms) : 0, 3985
IAST [baseline] (24.842 ms) : 0, 24842
IAST [candidate] (24.999 ms) : 0, 24999
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (813.275 ms) : 0, 813275
BytebuddyAgent [candidate] (813.919 ms) : 0, 813919
GlobalTracer [baseline] (231.321 ms) : 0, 231321
GlobalTracer [candidate] (231.221 ms) : 0, 231221
AppSec [baseline] (35.122 ms) : 0, 35122
AppSec [candidate] (35.16 ms) : 0, 35160
Debugger [baseline] (6.15 ms) : 0, 6150
Debugger [candidate] (6.044 ms) : 0, 6044
Remote Config [baseline] (617.579 µs) : 0, 618
Remote Config [candidate] (587.373 µs) : 0, 587
Telemetry [baseline] (8.662 ms) : 0, 8662
Telemetry [candidate] (8.503 ms) : 0, 8503
Flare Poller [baseline] (4.206 ms) : 0, 4206
Flare Poller [candidate] (4.164 ms) : 0, 4164
IAST [baseline] (26.492 ms) : 0, 26492
IAST [candidate] (26.299 ms) : 0, 26299
section profiling
ProfilingAgent [baseline] (106.973 ms) : 0, 106973
ProfilingAgent [candidate] (107.982 ms) : 0, 107982
crashtracking [baseline] (1.439 ms) : 0, 1439
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (720.314 ms) : 0, 720314
BytebuddyAgent [candidate] (724.68 ms) : 0, 724680
GlobalTracer [baseline] (216.869 ms) : 0, 216869
GlobalTracer [candidate] (218.426 ms) : 0, 218426
AppSec [baseline] (32.398 ms) : 0, 32398
AppSec [candidate] (33.239 ms) : 0, 33239
Debugger [baseline] (7.19 ms) : 0, 7190
Debugger [candidate] (7.377 ms) : 0, 7377
Remote Config [baseline] (691.096 µs) : 0, 691
Remote Config [candidate] (699.249 µs) : 0, 699
Telemetry [baseline] (15.723 ms) : 0, 15723
Telemetry [candidate] (15.294 ms) : 0, 15294
Flare Poller [baseline] (4.16 ms) : 0, 4160
Flare Poller [candidate] (5.084 ms) : 0, 5084
Profiling [baseline] (107.544 ms) : 0, 107544
Profiling [candidate] (109.261 ms) : 0, 109261
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~16aecb0648, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (4.371 ms) : 4321, 4420
. : milestone, 4371,
iast (9.718 ms) : 9550, 9887
. : milestone, 9718,
iast_FULL (14.455 ms) : 14168, 14742
. : milestone, 14455,
iast_GLOBAL (10.364 ms) : 10178, 10549
. : milestone, 10364,
profiling (8.837 ms) : 8700, 8974
. : milestone, 8837,
tracing (7.872 ms) : 7759, 7986
. : milestone, 7872,
section candidate
no_agent (4.516 ms) : 4465, 4567
. : milestone, 4516,
iast (9.883 ms) : 9714, 10053
. : milestone, 9883,
iast_FULL (14.02 ms) : 13740, 14300
. : milestone, 14020,
iast_GLOBAL (10.677 ms) : 10489, 10865
. : milestone, 10677,
profiling (8.79 ms) : 8644, 8935
. : milestone, 8790,
tracing (8.024 ms) : 7908, 8141
. : milestone, 8024,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~16aecb0648, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (37.119 ms) : 36825, 37414
. : milestone, 37119,
appsec (47.606 ms) : 47189, 48024
. : milestone, 47606,
code_origins (43.5 ms) : 43110, 43890
. : milestone, 43500,
iast (43.27 ms) : 42889, 43652
. : milestone, 43270,
profiling (46.382 ms) : 45928, 46836
. : milestone, 46382,
tracing (45.571 ms) : 45174, 45969
. : milestone, 45571,
section candidate
no_agent (36.856 ms) : 36560, 37152
. : milestone, 36856,
appsec (50.118 ms) : 49676, 50560
. : milestone, 50118,
code_origins (44.167 ms) : 43799, 44535
. : milestone, 44167,
iast (43.928 ms) : 43559, 44296
. : milestone, 43928,
profiling (47.832 ms) : 47372, 48292
. : milestone, 47832,
tracing (43.22 ms) : 42852, 43589
. : milestone, 43220,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~16aecb0648, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (15.143 s) : 15143000, 15143000
. : milestone, 15143000,
appsec (14.947 s) : 14947000, 14947000
. : milestone, 14947000,
iast (18.387 s) : 18387000, 18387000
. : milestone, 18387000,
iast_GLOBAL (18.038 s) : 18038000, 18038000
. : milestone, 18038000,
profiling (15.679 s) : 15679000, 15679000
. : milestone, 15679000,
tracing (15.168 s) : 15168000, 15168000
. : milestone, 15168000,
section candidate
no_agent (15.033 s) : 15033000, 15033000
. : milestone, 15033000,
appsec (15.089 s) : 15089000, 15089000
. : milestone, 15089000,
iast (18.577 s) : 18577000, 18577000
. : milestone, 18577000,
iast_GLOBAL (18.023 s) : 18023000, 18023000
. : milestone, 18023000,
profiling (15.19 s) : 15190000, 15190000
. : milestone, 15190000,
tracing (14.978 s) : 14978000, 14978000
. : milestone, 14978000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~16aecb0648, baseline=1.55.0-SNAPSHOT~24adc9a61e
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.455 ms) : 2404, 2505
. : milestone, 2455,
iast (2.205 ms) : 2142, 2268
. : milestone, 2205,
iast_GLOBAL (2.245 ms) : 2181, 2308
. : milestone, 2245,
profiling (2.49 ms) : 2321, 2659
. : milestone, 2490,
tracing (2.013 ms) : 1964, 2062
. : milestone, 2013,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.457 ms) : 2407, 2507
. : milestone, 2457,
iast (2.198 ms) : 2135, 2261
. : milestone, 2198,
iast_GLOBAL (2.24 ms) : 2177, 2304
. : milestone, 2240,
profiling (2.041 ms) : 1990, 2092
. : milestone, 2041,
tracing (2.02 ms) : 1970, 2069
. : milestone, 2020,
|
amarziali
reviewed
Oct 10, 2025
| controller(SUCCESS, new Closure[Response](null) { | ||
| override def call(): Response = { | ||
| response.ok(SUCCESS.getBody) | ||
| controller( |
There was a problem hiding this comment.
while those got formatted?
There was a problem hiding this comment.
Resolving as discussed offline.
For reference:
amarziali
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Properly declare the kotlin plugin via
plugins {}block. Configure kotlin version via the kotlin extension rather than plugin version.Motivation
Some projects used the
buildscriptblock to configure the project's plugins in this case the kotlin plugin, which is not recommended anymore since quite a few versions in gradle. Also, this generated the following warning :Additional Notes
Note
Actually fixing spotless showed that some scala files files were not properly formatted. This PR had to format those files that to pass.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]