-
Notifications
You must be signed in to change notification settings - Fork 313
Remove the warning on kotlin plugin warning #9711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1e8ce73
4caa486
796f1aa
ca06f36
16aecb0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,24 @@ | ||
import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar | ||
|
||
buildscript { | ||
repositories { | ||
mavenCentral() | ||
} | ||
|
||
dependencies { | ||
classpath group: 'org.jetbrains.kotlin', name: 'kotlin-gradle-plugin', version: libs.versions.kotlin.get() | ||
} | ||
} | ||
Comment on lines
-3
to
-11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, this buildscript was not configured to use our maven proxy |
||
import org.jetbrains.kotlin.gradle.dsl.JvmTarget | ||
import org.jetbrains.kotlin.gradle.dsl.KotlinVersion | ||
|
||
plugins { | ||
id 'com.gradleup.shadow' | ||
id 'org.jetbrains.kotlin.jvm' | ||
} | ||
|
||
apply from: "$rootDir/gradle/java.gradle" | ||
apply from: "$rootDir/gradle/version.gradle" | ||
apply from: "$rootDir/gradle/test-with-kotlin.gradle" | ||
|
||
kotlin { | ||
compilerOptions { | ||
jvmTarget = JvmTarget.JVM_1_8 | ||
apiVersion = KotlinVersion.KOTLIN_1_6 | ||
languageVersion = KotlinVersion.KOTLIN_1_6 | ||
} | ||
} | ||
|
||
minimumBranchCoverage = 0.0 | ||
minimumInstructionCoverage = 0.0 | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,14 +7,12 @@ import javax.inject.Inject | |
|
||
import play.api.mvc._ | ||
|
||
/** | ||
* This controller creates an `Action` to handle HTTP requests to the | ||
/** This controller creates an `Action` to handle HTTP requests to the | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note can ignore the |
||
* application's work page which does busy wait to simulate some work | ||
*/ | ||
class HomeController @Inject()(cc: ControllerComponents) extends AbstractController(cc) { | ||
class HomeController @Inject() (cc: ControllerComponents) extends AbstractController(cc) { | ||
|
||
/** | ||
* Create an Action to perform busy wait | ||
/** Create an Action to perform busy wait | ||
*/ | ||
def doGet(workTimeMS: Option[Long], error: Option[String]) = Action { | ||
implicit request: Request[AnyContent] => | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No instrumentation is written in Kotlin, and as such there no post-processing involved.