Add new supported OTel integrations #28253
Conversation
github-actions
bot
added
Architecture
There was a problem hiding this comment.
one small note: there's an apache dashboard here that we can add a screenshot in for: https://app.datadoghq.com/screen/integration/19/apache---overview
|
Editorial review: DOCS-10472 |
There was a problem hiding this comment.
left some feedback, generally looks good!
I do wonder about how the concept of OTel integrations squares with our general concept of Datadog integrations (and LLM Obs integrations, and potentially other special case integrations) but that's a bigger conversation for a later day.
| @@ -17,7 +17,7 @@ OTel Kafka Metrics Remapping is in public alpha. It is available in versions >= | |||
|
|
|||
| The [Kafka metrics receiver][1], [JMX Receiver][2]/ [JMX Metrics Gatherer][3] allow collecting Kafka metrics and access to the out of the box [Kafka Dashboard][7], "Kafka, Zookeeper and Kafka Consumer Overview". | |||
|
|
|||
| Please note that the [JMX Receiver][2] and [JMX Metrics Gatherer][3] should be considered as replacements. They collect the same set of metrics ([JMX Receiver][2] launches the [JMX Metrics Gatherer][3]). | |||
| **Note**: the [JMX Receiver][2] and [JMX Metrics Gatherer][3] should be considered as replacements. They collect the same set of metrics ([JMX Receiver][2] launches the [JMX Metrics Gatherer][3]). | |||
There was a problem hiding this comment.
I'm having some trouble understanding the landscape of the Kafka metrics receiver, JMX Receiver, and JMX Metrics Gatherer. I can sort of guess that JMX Receiver and JMX Metrics Gatherer are always used together, and this pair is an alternative to the Kafka metrics receiver—is that true? When would you use one over the other?
As-is, this first sentence could be interpreted to mean that the JMX Receiver and JMX Metrics Gatherer are replacements for each other, which seems misleading.
There was a problem hiding this comment.
Good point! I will update this in a follow-up PR.
| - name: Java | ||
| url: opentelemetry/integrations/runtime_metrics/java | ||
| identifier: otel_runtime_metrics_java | ||
| parent: otel_runtime_metrics | ||
| weight: 8101 | ||
| - name: .NET | ||
| url: opentelemetry/integrations/runtime_metrics/dotnet | ||
| identifier: otel_runtime_metrics_dotnet | ||
| parent: otel_runtime_metrics | ||
| weight: 8102 | ||
| - name: Go | ||
| url: opentelemetry/integrations/runtime_metrics/go | ||
| identifier: otel_runtime_metrics_go | ||
| parent: otel_runtime_metrics | ||
| weight: 8103 |
There was a problem hiding this comment.
These menu items aren't showing up in the staging preview. Is it because the weights are off? (they're 8101/8102/8103 while the siblings are 810, 811)
There was a problem hiding this comment.
Weird! I see them?
There was a problem hiding this comment.
oh! my bad, I didn't realize they were nested like that. ignore my comment!!
Co-authored-by: cecilia saixue watt <[email protected]>
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
* Add new supported OTel metrics. * Add Apache metrics dashboard image. * Quick style fixes. * Apply suggestions from code review Co-authored-by: cecilia saixue watt <[email protected]> --------- Co-authored-by: cecilia saixue watt <[email protected]>
* Add new supported OTel metrics. * Add Apache metrics dashboard image. * Quick style fixes. * Apply suggestions from code review Co-authored-by: cecilia saixue watt <[email protected]> --------- Co-authored-by: cecilia saixue watt <[email protected]>
What does this PR do? What is the motivation?
Add new supported OTel integrations.
Preview
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes