Skip to content

fix(agent-data-plane): update config docs around remote_agent.configstream.*#1590

Open
rahulkaukuntla wants to merge 2 commits into
mainfrom
rahul/add-new-option
Open

fix(agent-data-plane): update config docs around remote_agent.configstream.*#1590
rahulkaukuntla wants to merge 2 commits into
mainfrom
rahul/add-new-option

Conversation

@rahulkaukuntla
Copy link
Copy Markdown
Contributor

Summary

Refer to this PR

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

References

@rahulkaukuntla rahulkaukuntla requested a review from a team as a code owner May 5, 2026 17:50
@dd-octo-sts dd-octo-sts Bot added the area/docs Reference documentation. label May 5, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f400688384

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"python3_linter_timeout",
"python_lazy_loading",
"remote_agent.configstream.enabled",
"remote_agent.configstream.consumer.enabled",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the replaced configstream flag

When syncing the Datadog Agent PR referenced by this change, remote_agent.configstream.enabled is replaced by remote_agent.configstream.consumer.enabled rather than remaining alongside it; adding the new key without removing the old one leaves the compatibility inventory treating a removed core-agent setting as still known/not-applicable. Remove the old remote_agent.configstream.enabled entry when adding this replacement so the docs data matches the upstream config set.

Useful? React with 👍 / 👎.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 5, 2026

Binary Size Analysis (Agent Data Plane)

Target: 0f0001b (baseline) vs 4c72b0d (comparison) diff
Analysis Type: Stripped binaries (debug symbols excluded)
Baseline Size: 37.08 MiB
Comparison Size: 37.08 MiB
Size Change: +0 B (+0.00%)
Pass/Fail Threshold: +5%
Result: PASSED ✅

Changes by Module

Module File Size Symbols
anon.4f8fd67d74ae1f1600187cfeb0121be9.1.llvm.14224362687800510754 +130 B 1
anon.4f8fd67d74ae1f1600187cfeb0121be9.1.llvm.13252133868169429772 -130 B 1
anon.4f8fd67d74ae1f1600187cfeb0121be9.4.llvm.14224362687800510754 +115 B 1
anon.4f8fd67d74ae1f1600187cfeb0121be9.4.llvm.13252133868169429772 -115 B 1
anon.4f8fd67d74ae1f1600187cfeb0121be9.3.llvm.14224362687800510754 +109 B 1
anon.4f8fd67d74ae1f1600187cfeb0121be9.3.llvm.13252133868169429772 -109 B 1
anon.4f8fd67d74ae1f1600187cfeb0121be9.0.llvm.14224362687800510754 +97 B 1
anon.4f8fd67d74ae1f1600187cfeb0121be9.0.llvm.13252133868169429772 -97 B 1
anon.4f8fd67d74ae1f1600187cfeb0121be9.2.llvm.14224362687800510754 +95 B 1
anon.4f8fd67d74ae1f1600187cfeb0121be9.2.llvm.13252133868169429772 -95 B 1

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +130  [NEW]     +40    anon.4f8fd67d74ae1f1600187cfeb0121be9.1.llvm.14224362687800510754
  [NEW]    +115  [NEW]     +25    anon.4f8fd67d74ae1f1600187cfeb0121be9.4.llvm.14224362687800510754
  [NEW]    +109  [NEW]     +19    anon.4f8fd67d74ae1f1600187cfeb0121be9.3.llvm.14224362687800510754
  [NEW]     +97  [NEW]      +7    anon.4f8fd67d74ae1f1600187cfeb0121be9.0.llvm.14224362687800510754
  [NEW]     +95  [NEW]      +5    anon.4f8fd67d74ae1f1600187cfeb0121be9.2.llvm.14224362687800510754
  [DEL]     -95  [DEL]      -5    anon.4f8fd67d74ae1f1600187cfeb0121be9.2.llvm.13252133868169429772
  [DEL]     -97  [DEL]      -7    anon.4f8fd67d74ae1f1600187cfeb0121be9.0.llvm.13252133868169429772
  [DEL]    -109  [DEL]     -19    anon.4f8fd67d74ae1f1600187cfeb0121be9.3.llvm.13252133868169429772
  [DEL]    -115  [DEL]     -25    anon.4f8fd67d74ae1f1600187cfeb0121be9.4.llvm.13252133868169429772
  [DEL]    -130  [DEL]     -40    anon.4f8fd67d74ae1f1600187cfeb0121be9.1.llvm.13252133868169429772
  [ = ]       0  [ = ]       0    TOTAL

@rahulkaukuntla rahulkaukuntla changed the title add the option remote_agent.configstream.consumer.enabled (fix) add the option remote_agent.configstream.consumer.enabled May 5, 2026
@rahulkaukuntla rahulkaukuntla changed the title (fix) add the option remote_agent.configstream.consumer.enabled fix: add the option remote_agent.configstream.consumer.enabled May 5, 2026
@rahulkaukuntla rahulkaukuntla changed the title fix: add the option remote_agent.configstream.consumer.enabled fix(agent-data-plane): add the option remote_agent.configstream.consumer.enabled May 5, 2026
@rahulkaukuntla rahulkaukuntla changed the title fix(agent-data-plane): add the option remote_agent.configstream.consumer.enabled fix(agent-data-plane): add the option remote_agent.configstream.consumer.enabled and remove remote_agent.configstream.enabled May 5, 2026
@tobz tobz changed the title fix(agent-data-plane): add the option remote_agent.configstream.consumer.enabled and remove remote_agent.configstream.enabled fix(agent-data-plane): update config docs around remote_agent.configstream.* May 5, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 5, 2026

Regression Detector (Agent Data Plane)

Regression Detector Results

Run ID: 257e6300-4474-4ba4-9490-aaea69f3da87

Baseline: 0f0001b
Comparison: 4c72b0d
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs_5mb_memory memory utilization +17.04 [+16.58, +17.50] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput +0.01 [-0.11, +0.14] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization -1.23 [-6.01, +3.54] 1 (metrics) (profiles) (logs)

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otlp_ingest_logs_5mb_memory memory utilization +17.04 [+16.58, +17.50] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_cpu % cpu utilization +6.60 [-50.82, +64.03] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_cpu % cpu utilization +4.55 [-0.78, +9.88] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_cpu % cpu utilization +1.65 [-0.40, +3.70] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_cpu % cpu utilization +1.51 [-4.22, +7.24] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_throughput ingress throughput +0.19 [+0.11, +0.27] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_memory memory utilization +0.19 [+0.05, +0.33] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_memory memory utilization +0.15 [-0.01, +0.31] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_throughput ingress throughput +0.01 [-0.11, +0.14] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_throughput ingress throughput +0.01 [-0.04, +0.05] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_memory memory utilization +0.01 [-0.23, +0.25] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_cpu % cpu utilization +0.00 [-28.97, +28.97] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_throughput ingress throughput +0.00 [-0.06, +0.06] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_throughput ingress throughput +0.00 [-0.18, +0.18] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_throughput ingress throughput -0.00 [-0.05, +0.05] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_throughput ingress throughput -0.00 [-0.17, +0.17] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory utilization -0.04 [-0.17, +0.09] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_memory memory utilization -0.06 [-0.20, +0.09] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_memory memory utilization -0.06 [-0.22, +0.09] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_throughput ingress throughput -0.07 [-0.15, +0.01] 1 (metrics) (profiles) (logs)
dsd_uds_10mb_3k_contexts_memory memory utilization -0.09 [-0.24, +0.06] 1 (metrics) (profiles) (logs)
dsd_uds_512kb_3k_contexts_memory memory utilization -0.09 [-0.24, +0.05] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory utilization -0.10 [-0.26, +0.06] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_5mb_cpu % cpu utilization -0.13 [-2.25, +1.99] 1 (metrics) (profiles) (logs)
dsd_uds_100mb_3k_contexts_memory memory utilization -0.17 [-0.32, -0.01] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_cpu % cpu utilization -0.20 [-1.52, +1.12] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_transform_5mb_throughput ingress throughput -0.23 [-0.30, -0.15] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_heavy memory utilization -0.26 [-0.39, -0.14] 1 (metrics) (profiles) (logs)
quality_gates_rss_idle memory utilization -0.30 [-0.34, -0.26] 1 (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory utilization -0.39 [-0.57, -0.22] 1 (metrics) (profiles) (logs)
dsd_uds_500mb_3k_contexts_throughput ingress throughput -0.67 [-0.79, -0.54] 1 (metrics) (profiles) (logs)
otlp_ingest_traces_ottl_filtering_5mb_cpu % cpu utilization -0.89 [-3.08, +1.29] 1 (metrics) (profiles) (logs)
otlp_ingest_logs_5mb_cpu % cpu utilization -1.23 [-6.01, +3.54] 1 (metrics) (profiles) (logs)
otlp_ingest_metrics_5mb_memory memory utilization -1.99 [-2.19, -1.80] 1 (metrics) (profiles) (logs)
dsd_uds_1mb_3k_contexts_cpu % cpu utilization -10.73 [-60.50, +39.03] 1 (metrics) (profiles) (logs)

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
quality_gates_rss_dsd_heavy memory_usage 10/10 123.25MiB ≤ 140MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_low memory_usage 10/10 40.33MiB ≤ 50MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_medium memory_usage 10/10 60.63MiB ≤ 75MiB (metrics) (profiles) (logs)
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 178.80MiB ≤ 200MiB (metrics) (profiles) (logs)
quality_gates_rss_idle memory_usage 10/10 27.64MiB ≤ 40MiB (metrics) (profiles) (logs)

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Reference documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant