Initial setup#1
Merged
Merged
Conversation
📝 WalkthroughWalkthroughIntroduces the Changespublic-slice-mirror CI pipeline
Sequence Diagram(s)sequenceDiagram
rect rgba(173, 216, 230, 0.5)
note over PhaseOne: phase-one job
PhaseOne->>Nix: nix build ./tests#default
Nix-->>PhaseOne: resolved store path
PhaseOne->>UploadAction: store-paths input
UploadAction->>UploadAction: write & validate store-paths.txt
UploadAction->>GitHubArtifacts: upload store-paths.txt artifact
PhaseOne->>Nix: nix flake check ./tests
end
rect rgba(144, 238, 144, 0.5)
note over SubsetMirror: subset-mirror job (needs phase-one)
SubsetMirror->>FlakeHubPush: push flake (directory: tests, private)
SubsetMirror->>GitHubArtifacts: download store-paths.txt
SubsetMirror->>SubsetMirror: nix path-info -r, reject -source
SubsetMirror->>FlakeHubCache: setup cache (flake-name)
SubsetMirror->>NixBuild: nix-build upload.nix (builtins.storePath entries)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/actions/upload-store-paths/action.yml:
- Line 36: Update the `actions/upload-artifact` version in the composite action
at `.github/actions/upload-store-paths/action.yml` line 36 to match the version
of `actions/download-artifact` used in `.github/workflows/subset-mirror.yml`
line 53. The upload-artifact is currently pinned to v7.0.1 while
download-artifact is v8.0.1; align both to the same major version (v8.0.1) to
ensure artifact handling compatibility across jobs and avoid potential breaking
changes introduced in major version updates.
In @.github/workflows/subset-mirror.yml:
- Around line 15-24: The GitHub workflow inputs `rolling` and `tag` are
documented as mutually exclusive but lack runtime validation. Add a validation
step in the workflow (before the FlakeHub push action) that checks if both
`rolling` is true AND `tag` is non-empty, and fails the workflow with a clear
error message if both conditions are met. This will enforce the mutual
exclusivity constraint and prevent undefined behavior when callers accidentally
provide both parameters.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 12699291-a37c-4053-85a5-8e7714256108
⛔ Files ignored due to path filters (1)
flake.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
.github/actions/upload-store-paths/action.yml.github/workflows/ci.yml.github/workflows/subset-mirror.ymlREADME.mdflake.nix
grahamc
force-pushed
the
push-tmpkumsrnlro
branch
from
d715f93 to
84d9e40
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/subset-mirror.yml:
- Line 33: The custom self-hosted runner label UbuntuLatest32Cores128G is used
in `.github/workflows/subset-mirror.yml` at line 33 and
`.github/workflows/ci.yml` at line 10, but is not documented or registered.
Create a new `.github/actionlint.yaml` configuration file to document this
custom runner label in the runner labels section. This will suppress actionlint
linter warnings and ensure proper documentation that the custom runner is
intentionally used. No changes are needed to the workflow files themselves; they
already correctly reference the custom runner, but the actionlint configuration
is required to validate and document its existence.
In `@README.md`:
- Around line 88-95: The `subset-mirror` workflow input table in the README is
missing documentation for the `directory` input parameter that is actually
defined in the workflow. Add a new row to the input table for the `directory`
parameter with the required status set to "no", default value set to ".", and
include an appropriate description explaining that it specifies the directory
path for the subset mirror operation.
- Around line 14-64: The documentation contradicts itself by recommending
pinning to a tag or commit SHA instead of `@main`, but the example uses `@main` in
two places. In the example YAML, replace `@main` with a specific version reference
(such as a version tag like `@v1` or a commit SHA) in both the upload-store-paths
action reference and the subset-mirror workflow reference. This will align the
example with the stated best practice and demonstrate the recommended versioning
approach to users.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 25dc8555-85e8-43c2-a1d5-d421caeba1b4
⛔ Files ignored due to path filters (1)
tests/flake.lockis excluded by!**/*.lock
📒 Files selected for processing (5)
.github/actions/upload-store-paths/action.yml.github/workflows/ci.yml.github/workflows/subset-mirror.ymlREADME.mdtests/flake.nix
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/actions/upload-store-paths/action.yml
cole-h
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Documentation