Fixups

[cole-h]

Summary by CodeRabbit

• New Features
  • Workflow now accepts an input parameter to configure the Git reference for checkout operations, allowing flexible branch and revision selection
  • Added a boolean input to optionally enable or disable the FlakeHub push integration step based on workflow requirements
  • Enhanced store path parsing to better handle different input formats and improve workflow reliability

[coderabbitai]

📝 Walkthrough

Walkthrough

Two required inputs (checkout-ref and flakehub-push) are added to the workflow_call interface of subset-mirror.yml. The actions/checkout step now uses inputs.checkout-ref, the flakehub-push step is conditioned on inputs.flakehub-push, and store-paths.txt parsing is changed to split on whitespace rather than newlines.

Changes

Subset Mirror Workflow Parameterization

Layer / File(s)	Summary
New workflow inputs and step wiring .github/workflows/subset-mirror.yml	Declares checkout-ref (required string) and flakehub-push (required boolean) under workflow_call.inputs. Wires checkout-ref into the actions/checkout ref field, gates the DeterminateSystems/flakehub-push step on inputs.flakehub-push, and changes Nix store-paths.txt parsing to split on [[:space:]]+ instead of newline-separated entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

• DeterminateSystems/public-slice-mirror#1: Introduced the original subset-mirror workflow logic that this PR directly extends by parameterizing checkout ref and gating the FlakeHub push step.

Poem

🐇 Hoppity-hop through the workflow gate,
A boolean decides the FlakeHub fate!
The checkout ref now bends to your will,
Whitespace splits the paths — what a thrill.
No more hardcoded defaults to fight,
The mirror now flexes left and right! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Fixups' is vague and generic, using a non-descriptive term that doesn't convey meaningful information about the specific changes made.	Use a more descriptive title that captures the primary changes, such as 'Add workflow inputs for checkout-ref and flakehub-push gate' or 'Make subset-mirror workflow inputs configurable'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fixups

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/subset-mirror.yml:
- Around line 30-37: The new required inputs checkout-ref and flakehub-push
added to the subset-mirror.yml workflow are not being provided by the calling
workflow in ci.yml at lines 40-48. Update the workflow call in ci.yml to provide
values for both of these new required inputs (checkout-ref and flakehub-push) so
that the workflow call will not fail due to missing required parameters.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aa73b77c-b205-43c1-a9a2-90732fd584b3

📥 Commits

Reviewing files that changed from the base of the PR and between 381c2a4 and a49b4e6.

📒 Files selected for processing (1)

• .github/workflows/subset-mirror.yml

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Find all workflow files that call subset-mirror.yml and verify they provide the new required inputs

rg -n -A 10 'uses:.*subset-mirror\.yml' --glob '*.yml' --glob '*.yaml'

Repository: DeterminateSystems/public-slice-mirror

Length of output: 231

---

🏁 Script executed:

#!/bin/bash
# List workflow files in .github/workflows
git ls-files .github/workflows/ | head -20

Repository: DeterminateSystems/public-slice-mirror

Length of output: 143

---

🏁 Script executed:

cat -n .github/workflows/ci.yml

Repository: DeterminateSystems/public-slice-mirror

Length of output: 1721

---

🏁 Script executed:

cat -n .github/workflows/subset-mirror.yml

Repository: DeterminateSystems/public-slice-mirror

Length of output: 4613

---

Breaking change: new required inputs will break existing caller.

The workflow in ci.yml (lines 40-48) calls subset-mirror.yml but only provides flake-name and directory. The new required inputs checkout-ref and flakehub-push are not supplied, causing the workflow call to fail.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/subset-mirror.yml around lines 30 - 37, The new required
inputs checkout-ref and flakehub-push added to the subset-mirror.yml workflow
are not being provided by the calling workflow in ci.yml at lines 40-48. Update
the workflow call in ci.yml to provide values for both of these new required
inputs (checkout-ref and flakehub-push) so that the workflow call will not fail
due to missing required parameters.

[cole-h]

ok

[coderabbitai]

@cole-h, sounds good! Just to confirm — the fix still needs to be applied in .github/workflows/ci.yml to pass both checkout-ref and flakehub-push when calling subset-mirror.yml. Let me know if you'd like a suggested snippet for those additions.