Skip to content

Fixups #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cole-h merged 2 commits into from
Jun 15, 2026
Merged

Fixups #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91db671
fixup: require checkout-ref, flakehub-push
cole-h Jun 15, 2026
a49b4e6
fixup: split on all whitespace, not just newlines
cole-h Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/subset-mirror.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ on:
required: false
type: string
default: "."
checkout-ref:
description: The ref to checkout
required: true
type: string
flakehub-push:
description: Push a release to FlakeHub.
required: true
type: boolean
Comment on lines +30 to +37

@coderabbitai coderabbitai Bot Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Find all workflow files that call subset-mirror.yml and verify they provide the new required inputs

rg -n -A 10 'uses:.*subset-mirror\.yml' --glob '*.yml' --glob '*.yaml'

Repository: DeterminateSystems/public-slice-mirror

Length of output: 231

🏁 Script executed:

#!/bin/bash
# List workflow files in .github/workflows
git ls-files .github/workflows/ | head -20

Repository: DeterminateSystems/public-slice-mirror

Length of output: 143

🏁 Script executed:

cat -n .github/workflows/ci.yml

Repository: DeterminateSystems/public-slice-mirror

Length of output: 1721

🏁 Script executed:

cat -n .github/workflows/subset-mirror.yml

Repository: DeterminateSystems/public-slice-mirror

Length of output: 4613

Breaking change: new required inputs will break existing caller.

The workflow in ci.yml (lines 40-48) calls subset-mirror.yml but only provides flake-name and directory. The new required inputs checkout-ref and flakehub-push are not supplied, causing the workflow call to fail.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/subset-mirror.yml around lines 30 - 37, The new required
inputs checkout-ref and flakehub-push added to the subset-mirror.yml workflow
are not being provided by the calling workflow in ci.yml at lines 40-48. Update
the workflow call in ci.yml to provide values for both of these new required
inputs (checkout-ref and flakehub-push) so that the workflow call will not fail
due to missing required parameters.

@cole-h cole-h Jun 15, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@coderabbitai coderabbitai Bot Jun 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cole-h, sounds good! Just to confirm — the fix still needs to be applied in .github/workflows/ci.yml to pass both checkout-ref and flakehub-push when calling subset-mirror.yml. Let me know if you'd like a suggested snippet for those additions.


jobs:
subset-mirror:
Expand All @@ -37,11 +45,13 @@ jobs:
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
ref: ${{ inputs.checkout-ref }}
persist-credentials: false

- uses: DeterminateSystems/determinate-nix-action@29680e33cbf947967d8a1f9798654c329b3d49be # v3.21.1

- uses: "DeterminateSystems/flakehub-push@3135d10865f2938b309b1fa8f7941c48fe948de8"
if: ${{ inputs.flakehub-push }}
with:
name: ${{ inputs.flake-name }}
rolling: ${{ inputs.rolling }}
Expand Down Expand Up @@ -88,7 +98,7 @@ jobs:
storePathsFile = ./store-paths.txt;
lines = builtins.filter
(line: builtins.isString line && line != "")
(builtins.split "\n" (builtins.readFile storePathsFile));
(builtins.split "[[:space:]]+" (builtins.readFile storePathsFile));
in
derivation {
name = "propagate";
Expand Down