Delay Auto-Update Until All Operations Have Completed#3340
Closed
mrixner wants to merge 2 commits intoDevolutions:mainfrom
Closed
Delay Auto-Update Until All Operations Have Completed#3340mrixner wants to merge 2 commits intoDevolutions:mainfrom
mrixner wants to merge 2 commits intoDevolutions:mainfrom
Conversation
Martí Climent (marticliment)
requested changes
Feb 26, 2025
| !ReleaseLockForAutoupdate_Notification && | ||
| !ReleaseLockForAutoupdate_UpdateBanner) | ||
| !ReleaseLockForAutoupdate_UpdateBanner && | ||
| MainApp.Operations.AreThereRunningOperations()) |
Collaborator
There was a problem hiding this comment.
This approach doesn't work. You can test it by decreasing the build number on CoreData.cs
Contributor
Author
There was a problem hiding this comment.
Sorry, I'll look into it.
Contributor
Author
There was a problem hiding this comment.
I can't even get UniGetUI to delay updating until the MainWindow is opened, it's updating as soon as it starts right now. I honestly have no idea how to fix that, and while this would be a great feature to have I have no idea to debug why it isn't working, so I will close this PR and accept defeat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.
This PR has UniGetUI wait until all operations in the queue have finished before automatically updating.
Closes #3277