Skip to content

Delay Auto-Update Until All Operations Have Completed #3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mrixner wants to merge 2 commits into from
Closed

Delay Auto-Update Until All Operations Have Completed #3340

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67c8e21
Delay auto-update until all operations have completed
mrixner Feb 22, 2025
381d2bb
Use AreThereRunningOperations() method
marticliment Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/UniGetUI/AutoUpdater.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using UniGetUI.Core.Logging;
using UniGetUI.Core.SettingsEngine;
using UniGetUI.Core.Tools;
using UniGetUI.Interface;
using UniGetUI.Interface.Enums;

namespace UniGetUI;
Expand Down Expand Up @@ -262,11 +263,12 @@ private static async Task<bool> PrepairToLaunchInstaller(string installerLocatio
}
else
{
Logger.Debug("Waiting for mainWindow to be closed or for user to trigger the update from the notification...");
Logger.Debug("Waiting for mainWindow to be closed, operations to complete, or for user to trigger the update from the notification...");
while (
!ReleaseLockForAutoupdate_Window &&
!ReleaseLockForAutoupdate_Notification &&
!ReleaseLockForAutoupdate_UpdateBanner)
!ReleaseLockForAutoupdate_UpdateBanner &&
MainApp.Operations.AreThereRunningOperations())
Copy link
Copy Markdown
Collaborator

@marticliment Martí Climent (marticliment) Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach doesn't work. You can test it by decreasing the build number on CoreData.cs

Copy link
Copy Markdown
Contributor Author

@mrixner mrixner Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'll look into it.

Copy link
Copy Markdown
Contributor Author

@mrixner mrixner Mar 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't even get UniGetUI to delay updating until the MainWindow is opened, it's updating as soon as it starts right now. I honestly have no idea how to fix that, and while this would be a great feature to have I have no idea to debug why it isn't working, so I will close this PR and accept defeat.

{
await Task.Delay(100);
}
Expand Down
Loading