Skip to content

Always Update Indexes#3385

Merged
Martí Climent (marticliment) merged 3 commits intoDevolutions:mainfrom
mrixner:always-update-indexes
Mar 2, 2025
Merged

Always Update Indexes#3385
Martí Climent (marticliment) merged 3 commits intoDevolutions:mainfrom
mrixner:always-update-indexes

Conversation

@mrixner
Copy link
Copy Markdown
Contributor

@mrixner mrixner commented Mar 1, 2025

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

In attempting to update bzip2 before pressing "update now" to the new 3.1.7 update, the bzip update fails (not due to UniGetUI, but due to vcpkg that was impacted by UniGetUI), and as microsoft/vcpkg#43297 suggests it's because a recent vcpkg commit changed the way the system works, however while commit 9e3482c in #3278 bootstraps vcpkg upon UniGetUI opening (giving it the new version with the updated code), it doesn't git pull (as recommended by the above issue, avoiding the configuration being out-of-sync) unless this setting is enabled, causing idiosyncrasies and subtle issues. Things like this was why I hadn't done what 9e3482c did originally, as I've encountered many bugs in the past with different vcpkg versions not working with my current environment. While this is an issue I encountered due to a too-recent vcpkg version, most (if not all) I've encountered were because a new vcpkg version attempted to interact with an old vcpkg directory. This PR should hopefully fix some confusion and prevent some errors, keeping the vcpkg version and directory in sync.

Image

@marticliment Martí Climent (marticliment) merged commit 2edb5d5 into Devolutions:main Mar 2, 2025
2 checks passed
@mrixner mrixner deleted the always-update-indexes branch March 2, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants