Skip to content

Always Update Indexes #3385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martí Climent (marticliment) merged 3 commits into from
Mar 2, 2025
Merged

Always Update Indexes #3385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12026ec
Update Vcpkg.cs
mrixner Mar 1, 2025
6ee2026
Update SettingsPage.xaml.cs
mrixner Mar 1, 2025
eefcbb1
Merge branch 'main' into always-update-indexes
marticliment Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/UniGetUI.PackageEngine.Managers.Vcpkg/Vcpkg.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ public override void RefreshPackageIndexes()
var (vcpkgRootFound, vcpkgRoot) = GetVcpkgRoot();
var (gitFound, gitPath) = CoreTools.Which("git");

if (!found || !gitFound || !vcpkgRootFound || Settings.Get("DisableUpdateVcpkgGitPorts"))
if (!found || !gitFound || !vcpkgRootFound)
{
INativeTaskLogger logger = TaskLogger.CreateNew(LoggableTaskType.RefreshIndexes);
if (Settings.Get("DisableUpdateVcpkgGitPorts")) logger.Error("User has disabled updating sources");
Expand Down
8 changes: 0 additions & 8 deletions src/UniGetUI/Pages/SettingsPage.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
private readonly TextBlock BackupDirectoryLabel;
private readonly bool InterfaceLoaded;

public SettingsPage()

Check warning on line 38 in src/UniGetUI/Pages/SettingsPage.xaml.cs

View workflow job for this annotation

GitHub Actions / test-codebase 

Non-nullable field 'ResetBackupDirectory' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.

Check warning on line 38 in src/UniGetUI/Pages/SettingsPage.xaml.cs

View workflow job for this annotation

GitHub Actions / test-codebase 

Non-nullable field 'OpenBackupDirectory' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.

Check warning on line 38 in src/UniGetUI/Pages/SettingsPage.xaml.cs

View workflow job for this annotation

GitHub Actions / test-codebase 

Non-nullable field 'BackupDirectoryLabel' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
{
InitializeComponent();

Expand Down Expand Up @@ -245,14 +245,6 @@

// ----------------------------------------------------------------------------------------

CheckboxCard Vcpkg_UpdateGitPorts = new()
{
Text = CoreTools.Translate(
"Update vcpkg's Git portfiles automatically (requires Git installed)"),
SettingName = "DisableUpdateVcpkgGitPorts"
};
ExtraSettingsCards[PEInterface.Vcpkg].Add(Vcpkg_UpdateGitPorts);

// GetDefaultTriplet factors in the `DefaultVcpkgTriplet` setting as its first priority
Settings.SetValue("DefaultVcpkgTriplet", Vcpkg.GetDefaultTriplet());
ComboboxCard Vcpkg_DefaultTriplet = new()
Expand Down
Loading