fix: add 'review' to RUNTIME_MODES so normalizeMode accepts it#395
Open
nanaubusiness wants to merge 1 commit into
Open
fix: add 'review' to RUNTIME_MODES so normalizeMode accepts it#395nanaubusiness wants to merge 1 commit into
nanaubusiness wants to merge 1 commit into
Conversation
Previously VALID_MODES included 'review' but RUNTIME_MODES did not.
Setting PONYTAIL_DEFAULT_MODE=review passed config validation but
normalizeMode('review') returned null, silently falling back to 'full'.
Now 'review' is in both lists.
Closes DietrichGebert#377
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously VALID_MODES included 'review' but RUNTIME_MODES did not. Setting PONYTAIL_DEFAULT_MODE=review passed config validation but normalizeMode('review') returned null, silently falling back to 'full'. Now 'review' is consistently accepted in both contexts.
Closes #377