Skip to content

[No QA] Docs updates for E/A#95651 Status column in Expensify Card list#95845

Open
MelvinBot wants to merge 2 commits into
mainfrom
claude-docs-expensifyCardStatusColumn
Open

[No QA] Docs updates for E/A#95651 Status column in Expensify Card list#95845
MelvinBot wants to merge 2 commits into
mainfrom
claude-docs-expensifyCardStatusColumn

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Follow-up documentation for #95651, which adds a Status column to the workspace Expensify Card list so admins can see each card's lifecycle state (Pending order / Shipped / Active / Inactive) at a glance and sort by it.

This updates the Monitor and Manage Cards section of Set-Up-and-Manage-the-Expensify-Card.md with a new section, What the Status column shows in the Expensify Card list, explaining:

  • What each status means (Pending order, Shipped, Active, Inactive)
  • That the column is sortable
  • That the column is hidden on narrow/medium screens

All feature names and labels match the UI strings introduced in the PR (common.statusStatus; statusPendingOrder/statusShipped/statusActive/statusInactive).

Fixed Issues

Related PR: #95651

Tests

N/A — documentation only.

QA Steps

N/A — documentation only.

PR Author Checklist

  • I verified the changes reflect the current UI labels and behavior

@shawnborton, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 10, 2026
@shawnborton

Copy link
Copy Markdown
Contributor

cc @joekaufmanexpensify for extra eyes too.

@joekaufmanexpensify

joekaufmanexpensify commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot a few adjustments:

  • Pending order should be: A physical card has been issued but not yet ordered by the cardholder.
  • Active should be: The card is ready to use. Virtual cards are immediately **Active** once issued.

Can you please update the PR to reflect these?

@joekaufmanexpensify joekaufmanexpensify self-requested a review July 13, 2026 15:49
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Thanks joekaufmanexpensify! Here are the two wording changes you requested, targeting Set-Up-and-Manage-the-Expensify-Card.md:

Pending order — currently:

Pending order — A physical card has been ordered but not yet shipped.

Pending order — A physical card has been issued but not yet ordered by the cardholder.

Active — currently:

Active — The card is issued and ready to use. Virtual cards show as Active once issued.

Active — The card is ready to use. Virtual cards are immediately Active once issued.


⚠️ I can't push these changes myself: I can only make code changes when directed by the PR author, an assignee, or an existing co-author, and you're not currently listed as any of those on this PR. To have me implement this, the PR assignee (shawnborton) or author should reply tagging me, or add you as an assignee — then re-ping me and I'll make the edits.

@joekaufmanexpensify joekaufmanexpensify removed their request for review July 13, 2026 18:04
@joekaufmanexpensify joekaufmanexpensify self-assigned this Jul 13, 2026
@joekaufmanexpensify

joekaufmanexpensify commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot I just added myself as assignee. Can you please make the change now?

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

1 similar comment
@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

@joekaufmanexpensify

Copy link
Copy Markdown
Contributor

Not sure about the above Melvin issues, so I just committed the updates myself. Changes here look good. Marking as ready for review. 👍

@joekaufmanexpensify joekaufmanexpensify marked this pull request as ready for review July 14, 2026 13:12
@github-actions github-actions Bot changed the title Docs updates for E/A#95651 Status column in Expensify Card list [No QA] Docs updates for E/A#95651 Status column in Expensify Card list Jul 14, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://350e7084.helpdot.pages.dev ⚡️

Updated articles:


## What the Status column shows in the Expensify Card list

The Expensify Card list includes a **Status** column so you can see each card's lifecycle state at a glance without opening the card. Click the **Status** column header to sort the list by status.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step formatting: "Click the Status column header to sort the list by status." is a procedural action but is embedded in a paragraph. Per HELP_AUTHORING_GUIDELINES.md Section 5, procedural instructions should be sequential numbered steps, not inline prose.

- **Active** — The card is ready to use. Virtual cards are immediately **Active** once issued.
- **Inactive** — The card is frozen or otherwise not currently usable.

**Note:** The **Status** column is hidden on narrow and medium screens. Widen your browser window or view the list on a larger screen to see it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-platform clarity: This note describes a web-only layout behavior ("narrow and medium screens", "Widen your browser window") but does not explicitly state the platform or address mobile. Per HELPSITE_NAMING_CONVENTIONS.md (Cross-Platform Clarity Rule), explicitly state the platform when behavior differs and don't leave mobile behavior implied.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single new section documenting the Status column in the Expensify Card list, explaining each lifecycle state (Pending order, Shipped, Active, Inactive) and noting the column's visibility behavior on narrow/medium screens. The addition is focused, self-contained, and consistent with the article's existing card-management workflow. Scoring below reflects only the 13 added lines.

Scores Summary

  • Readability: 9/10 - Clear, scannable prose. The status definitions use a clean bulleted list, and the sorting behavior and screen-size limitation are stated plainly.
  • AI Readiness: 8/10 - The heading is task/question-based ("What the Status column shows...") and includes the feature name, matching Section 2 and Section 6 of the authoring guidelines. No metadata changes were needed since this is an additive section under an existing article.
  • Style Compliance: 8/10 - UI labels (Status, status values) are bolded per the Section/Toggle referencing rules, and casing appears to match the UI. One minor item noted below.

Key Findings

  • Positive: The new heading follows the strict task-based heading rule and embeds the exact feature name ("Expensify Card list"), aiding semantic retrieval.
  • Positive: Status values are individually bolded and defined, and the sort action ("Click the Status column header") uses correct button/bold formatting.
  • Positive: The narrow/medium screen visibility caveat respects the Cross-Platform Clarity rule by explicitly stating the limitation rather than implying parity.
  • Minor: The inline lead-in "Note:" is acceptable as bold body text (it is not a heading), but the authoring guidelines discourage "Notes" as a section label. Consider folding the sentence into the paragraph to avoid the note-style prefix.
  • Minor: No screenshot placeholder was added. Per Section 8, list/settings states are good screenshot candidates; an HTML-comment placeholder showing the Status column could be considered (optional).

Recommendations

  • Optional: Rephrase the "Note:" lead-in into a plain sentence to fully align with the guideline's stance on note-style labels.
  • Optional: Add a non-rendered screenshot placeholder for the Status column view per Section 8.
  • Verify each status label and its casing exactly matches the product UI (exact-label rule).

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card.md - New section added documenting the Status column; compliant with heading, formatting, and terminology rules, with minor optional refinements.

Note: This review is based solely on the added lines in the PR diff. Pre-existing headings in the file were not scored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants