fixed my error in clearing the targets_reached_count dictionary#85
Merged
energy-in-joles merged 1 commit intomainfrom Jan 13, 2026
Merged
fixed my error in clearing the targets_reached_count dictionary#85energy-in-joles merged 1 commit intomainfrom
energy-in-joles merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the targets_reached_count dictionary was being cleared immediately after being initialized with robot IDs. The dictionary is populated in reset_field() and then _reset_metrics() was incorrectly clearing it, preventing proper tracking of target achievements.
Changes:
- Removed the erroneous
self.targets_reached_count = {}line from_reset_metrics()method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.