Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix synthetic shortname option handling #978

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tsteven4
Copy link
Collaborator

and make related options parameters bool.

the ozi and xcsv writers had ARGTYPE_BOOL options without defaults
for must upper, must unique and whitespace ok, but only used them
if they were not nullptr.
For ARGTYPE_BOOL without defaults false is signified by a value of nullptr.
But mkshort defaults whitespace ok and must unique to true, so they were
impossible to turn off.

add test for the above writers and the related options.

and make related options parameters bool.

the ozi and xcsv writers had ARGTYPE_BOOL options without defaults
for must upper, must unique and whitespace ok, but only used them
if they were not nullptr.
For ARGTYPE_BOOL without defaults false is signified by a value of nullptr.
But mkshort defaults whitespace ok and must unique to true, so they were
impossible to turn off.

add test for the above writers and the related options.
@tsteven4 tsteven4 marked this pull request as draft January 12, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant