Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix synthetic shortname option handling #978

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

fix synthetic shortname option handling #978

wants to merge 4 commits into from

Commits on Jan 11, 2023

  1. fix synthetic shortname option handling. 

    and make related options parameters bool.

the ozi and xcsv writers had ARGTYPE_BOOL options without defaults
for must upper, must unique and whitespace ok, but only used them
if they were not nullptr.
For ARGTYPE_BOOL without defaults false is signified by a value of nullptr.
But mkshort defaults whitespace ok and must unique to true, so they were
impossible to turn off.

add test for the above writers and the related options.
    @tsteven4
    tsteven4 committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    6e9a6f2 View commit details
    Browse the repository at this point in the history

  2. fool around with xcsv quoting for test.

    @tsteven4
    tsteven4 committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    30583a8 View commit details
    Browse the repository at this point in the history

  3. catch ozi reference files back up with xcsv fiddling.

    @tsteven4
    tsteven4 committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    e81a3da View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Merge branch 'master' into mkshortbools

    @tsteven4
    tsteven4 committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    d5ad41a View commit details
    Browse the repository at this point in the history