-
Notifications
You must be signed in to change notification settings - Fork 56
Semi-Automatic Camera Calibration #1707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -34,6 +26,28 @@ pub struct FieldDimensions { | |||
pub goal_depth: f32, | |||
} | |||
|
|||
impl Default for FieldDimensions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may be good for your test, but I'm not sure we want this.
People may be tempted to use this default instead of acquiring the actual values from the configuration file.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added #[cfg(test)] since that's what I need it for. What do you think of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we can't definde the default for SimulatorFieldDimensions
, that is used some times in the bevyhavior simulator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was arguing for keeping the derived Default
impl which just fills all the values with 0.
It may still be misused this way, but its much more likely to be noticed than if the implementation returns the standard SPL field dimensions.
Why? What?
Implement a new Twix-Panel for semi-automatic camera calibration.
Workflow:
Ideas for Next Iterations (Not This PR)
How to Test
Take a nao and try to follow the workflow described above.