Add replacement penalty striker #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackyBloxx
force-pushed
the
add_replacement_penalty_striker
branch
from
f84c885 to
8d4c505
Compare
|
tested in the morning: did not work correctly. Somehow the penalty kick against invisibles was percepted as a penalty kick against Hulks |
|
that is because we never got a message which team is the kicking team, because of the new rules we only get that information from the hand gestures from the ref and not from the controler |
|
this has to be postponed until after @ThagonDuarte merges the filter for free kicks |
JackyBloxx
force-pushed
the
add_replacement_penalty_striker
branch
from
8d4c505 to
d4aa55a
Compare
MaikRe
approved these changes
Apr 16, 2025
github-project-automation
bot
moved this from Request for Review
to Done
in Development
pejotejo
pushed a commit
that referenced
this pull request
Apr 16, 2025
* suport striker as replacement * in function * bevi * replacment_penalty_striker * rename function for role change in penalty kick * format * clippy * rebase * clippy --------- Co-authored-by: MaikRe <[email protected]>
pejotejo
pushed a commit
to pejotejo/hulk
that referenced
this pull request
Apr 16, 2025
* suport striker as replacement * in function * bevi * replacment_penalty_striker * rename function for role change in penalty kick * format * clippy * rebase * clippy --------- Co-authored-by: MaikRe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
If we had a penalty kick and our striker got penelized we hadent any striker for the kick
Fixes #
ToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test
in a penalty kick penalize the striker and look if it got replaced
you could test it with bevi sim ingame_penalty_kick_striker_penalized