Skip to content

Disable realtime for hulks_webots explicitly #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tuxbotix
Copy link
Contributor

@tuxbotix tuxbotix commented Mar 15, 2025

Why? What?

This combines two feature flags to actually activate realtime. I don't like it, but this is the easy-way out without digging depe into pepsi or cargo.

Fixes #1651

ToDo / Known Issues

There should be a better way than this

Ideas for Next Iterations (Not This PR)

If there are some improvements that could be done in a next iteration, describe them here.

How to Test

The following should run (while webots is active) without the "failed to set scheduler" error in #1651.

pepsi run --bin hulks_webots

@github-project-automation github-project-automation bot moved this to Request for Review in Development Mar 15, 2025
@tuxbotix tuxbotix marked this pull request as ready for review March 15, 2025 10:51
@tuxbotix tuxbotix requested a review from schmidma March 15, 2025 10:51
@tuxbotix tuxbotix force-pushed the realtime_switching branch from dc9f330 to bf087a4 Compare March 15, 2025 10:53
@paudar
Copy link
Contributor

paudar commented Apr 16, 2025

The error no longer occurs.
Maybe you could give the feature a more self explaining name like is_webot

@tuxbotix
Copy link
Contributor Author

tuxbotix commented Apr 16, 2025

I'm a bit confused, did you mean with this PR the error is fixed or did I misunderstood? :D

As for naming, I agree this was a very quick hack and could be a better name. I renamed it to is_webots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Request for Review
Development

Successfully merging this pull request may close these issues.

Feature flags are absorbed from other projects when using Pepsi run (since Pepsi Max)
2 participants