Add individual and total node duration measurements #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@knoellle what is your take on this? Should we give this a go now? |
|
Yes!
|
oleflb
requested changes
Apr 15, 2025
| @@ -919,6 +926,8 @@ fn generate_execute_node_and_write_main_outputs( | |||
| ) | |||
| .wrap_err(#cycle_error_message)? | |||
| }; | |||
| let cycle_duration = cycle_start.elapsed().expect("time ran backwards"); | |||
Comment on lines
43
to
74
| cycler_structs | ||
| .cycle_times | ||
| .insert([ | ||
| InsertionRule::InsertField { | ||
| name: "total".to_string(), | ||
| }, | ||
| InsertionRule::AppendDataType { | ||
| data_type: Type::Verbatim(quote! { std::time::Duration }), | ||
| }, | ||
| ]) | ||
| .map_err(|source| Error::Hierarchy { | ||
| node: "total_cycle_node_timings".to_string(), | ||
| cycler: cycler.name.clone(), | ||
| source, | ||
| })?; | ||
| for node in cycler.iter_nodes() { | ||
| cycler_structs | ||
| .cycle_times | ||
| .insert([ | ||
| InsertionRule::InsertField { | ||
| name: node.name.to_case(Case::Snake), | ||
| }, | ||
| InsertionRule::AppendDataType { | ||
| data_type: Type::Verbatim(quote! { std::time::Duration }), | ||
| }, | ||
| ]) | ||
| .map_err(|source| Error::Hierarchy { | ||
| node: node.name.clone(), | ||
| cycler: cycler.name.clone(), | ||
| source, | ||
| })?; | ||
|
|
There was a problem hiding this comment.
This code is duplicated (for total and then for all nodes). Can you use something like chain to have only one for loop?
There was a problem hiding this comment.
I pulled the field insertion out of the for loop and added another with iter::once().chain(). Is this what you had in mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
Debugging #1822 was kind of annoying without proper timing measurements for node and cycle durations.
This PR expands on #710 and adds the
cycle_timingsfield to each cycler database. This includes a total time measurement from the start of the first node of a cycler until the last node's cycle function terminates, which is the same as the cycler recording timestamp. This can be used under$cycler.cycle_timings.total.Same as #710 did, this also adds node cycle durations for each individual node of a cycler. These can be accessed under
$cycler.cycle_timings.$nodeToDo / Known Issues
If this is a WIP describe which problems are to be fixed.
Ideas for Next Iterations (Not This PR)
If there are some improvements that could be done in a next iteration, describe them here.
How to Test
$cycler.cycle_timingsin a twix text panel.