fix: SkyBlockGardenCropMilstone calculation going from 0-45 instead of 1-46 #674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like someone missed prettier in the past, added a second commit. |
Kathund
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixed a bug where crop milestones would be calculated starting from 0, instead of 1. This resulted in them being lower than they actually are. Therefore, you could NEVER reach a crop milestone of 46 regarding to the code, which is clearly wrong.
Below are the logged milestones + the milestone average calculated from them.
Logs are from a maxxed garden Player:
Before:
After:
Also tested this on myself, who doesn't have fully maxed crop milestones:
My actual milestones are 28, 28, 46...
Before:
After:
pnpm test)pnpm lint)pnpm prettier)