Skip to content

fix: SkyBlockGardenCropMilstone calculation going from 0-45 instead of 1-46 #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2025
Merged

fix: SkyBlockGardenCropMilstone calculation going from 0-45 instead of 1-46 #674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f8e43b
fix cropmilestones
Yoshy2002 Oct 1, 2025
4528c56
prettier
Yoshy2002 Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Structures/MiniGames/SkyWars/SkyWars.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@
this.levelProgress = getSkyWarsLevelProgress(data?.skywars_experience);
this.levelFormatted = data?.levelFormatted
? data?.levelFormatted
?.replace(/§l/gm, '**')
?.replace(/§([a-f]|[1-9])/gm, '')
?.replace(/§r/gm, '')
?.replace(/§l/gm, '**')

Check failure on line 107 in src/Structures/MiniGames/SkyWars/SkyWars.ts

View workflow job for this annotation

GitHub Actions / check linting (eslint) 

Expected indentation of 8 spaces but found 10
?.replace(/§([a-f]|[1-9])/gm, '')

Check failure on line 108 in src/Structures/MiniGames/SkyWars/SkyWars.ts

View workflow job for this annotation

GitHub Actions / check linting (eslint) 

Expected indentation of 8 spaces but found 10
?.replace(/§r/gm, '')

Check failure on line 109 in src/Structures/MiniGames/SkyWars/SkyWars.ts

View workflow job for this annotation

GitHub Actions / check linting (eslint) 

Expected indentation of 8 spaces but found 10
: null;
this.prestige = getSkyWarsPrestige(this.level);
this.opals = data?.opals || 0;
Expand Down
28 changes: 14 additions & 14 deletions src/Structures/SkyBlock/Inventory/SkyBlockInventoryItem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,20 +88,20 @@
this.statsBook = data?.tag?.ExtraAttributes?.stats_book || null;
this.runes = data?.tag?.ExtraAttributes?.runes
? Object.keys(data?.tag?.ExtraAttributes?.runes).map(
(rune) => new SkyBlockInventoryItemRune({ id: rune, tier: data?.tag?.ExtraAttributes?.runes?.[rune] })
)
(rune) => new SkyBlockInventoryItemRune({ id: rune, tier: data?.tag?.ExtraAttributes?.runes?.[rune] })

Check failure on line 91 in src/Structures/SkyBlock/Inventory/SkyBlockInventoryItem.ts

View workflow job for this annotation

GitHub Actions / check linting (eslint) 

Expected indentation of 8 spaces but found 10
)

Check failure on line 92 in src/Structures/SkyBlock/Inventory/SkyBlockInventoryItem.ts

View workflow job for this annotation

GitHub Actions / check linting (eslint) 

Expected indentation of 6 spaces but found 8
: null;
this.reforge = data?.tag?.ExtraAttributes?.modifier || 'none';
this.hasArtOfWar = Boolean(data?.tag?.ExtraAttributes?.art_of_war_count || 0);
this.starCount = data?.tag?.ExtraAttributes?.upgrade_level || 0;
this.enchantments = data?.tag?.ExtraAttributes?.enchantments
? Object.keys(data?.tag?.ExtraAttributes?.enchantments).map(
(enchantment) =>
new SkyBlockInventoryItemEnchantment({
id: enchantment,
level: data?.tag?.ExtraAttributes?.enchantments?.[enchantment]
})
)
(enchantment) =>

Check failure on line 99 in src/Structures/SkyBlock/Inventory/SkyBlockInventoryItem.ts

View workflow job for this annotation

GitHub Actions / check linting (eslint) 

Expected indentation of 8 spaces but found 10
new SkyBlockInventoryItemEnchantment({

Check failure on line 100 in src/Structures/SkyBlock/Inventory/SkyBlockInventoryItem.ts

View workflow job for this annotation

GitHub Actions / check linting (eslint) 

Expected indentation of 10 spaces but found 12
id: enchantment,

Check failure on line 101 in src/Structures/SkyBlock/Inventory/SkyBlockInventoryItem.ts

View workflow job for this annotation

GitHub Actions / check linting (eslint) 

Expected indentation of 12 spaces but found 14
level: data?.tag?.ExtraAttributes?.enchantments?.[enchantment]

Check failure on line 102 in src/Structures/SkyBlock/Inventory/SkyBlockInventoryItem.ts

View workflow job for this annotation

GitHub Actions / check linting (eslint) 

Expected indentation of 12 spaces but found 14
})

Check failure on line 103 in src/Structures/SkyBlock/Inventory/SkyBlockInventoryItem.ts

View workflow job for this annotation

GitHub Actions / check linting (eslint) 

Expected indentation of 10 spaces but found 12
)
: null;
this.uuid = data?.tag?.ExtraAttributes?.uuid || null;
this.hotPotatoBookCount = data?.tag?.ExtraAttributes?.hot_potato_count || null;
Expand All @@ -126,12 +126,12 @@
this.isShiny = Boolean(data?.tag?.ExtraAttributes?.is_shiny || 0);
this.attributes = data?.tag?.ExtraAttributes?.attributes
? Object.keys(data?.tag?.ExtraAttributes?.attributes).map(
(attribute) =>
new SkyBlockInventoryItemAttribute({
id: attribute,
level: data?.tag?.ExtraAttributes?.attributes[attribute]
})
)
(attribute) =>
new SkyBlockInventoryItemAttribute({
id: attribute,
level: data?.tag?.ExtraAttributes?.attributes[attribute]
})
)
: null;
this.jalapenoCount = data?.tag?.ExtraAttributes?.jalapeono_count || null;
this.hecatombSRuns = data?.tag?.ExtraAttributes?.hecatomb_s_runs || null;
Expand Down
Loading