-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check_systemd: Fix executable name and include latest arguments #10035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please rebase the PR to get the GAs fixed and apart from that, you may want to consider adding this one missing option as well.
-i, --ignore-inactive-state
Ignore an inactive state on a specific unit. Oneshot
services for example are only active while running and
not enabled. The rest of the time they are inactive.
This option has only an affect if it is used with the
The executable name for check_systemd's dropped the `.py` suffix for version 2.0.3[0], released in April 2019[1]. However, the old name is still being referenced, both in documentation as well as in the ITL's CheckCommand's command, making it unusable. Closes #9547. [0]: Josef-Friedrich/check_systemd@v2.0.2...v2.0.3#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7 [1]: https://github.com/Josef-Friedrich/check_systemd/releases/tag/v2.0.3
While fixing the outdated command name in the Icinga 2 ITL[0], it was suggested to support the newer command line options there as well. To synchronize or harmonize the ITL definition and the CheckCommand shipped here, I made small changes to not break the ITL, as I would guess that more people are using the ITL definition instead of the shipped command.conf from here. The breaking changes were added to the CHANGELOG. [0]: Icinga/icinga2#10035
c9f9157
to
104ef2c
Compare
Rebased. I have also harmonized the arguments with the upstream As @RincewindsHat initially created the Edit: My patch was already merged upstream. They are fast! |
Initially I just wanted you to add the one missing argument |
104ef2c
to
f988236
Compare
Sorry @yhabteab, your comment somehow got lost at my end and I just found it by looking at some of my older PRs. I tried addressing your points. Please feel free to take another look. |
Harmonize the arguments with the upstream CheckCommand[0], including a patch to use the ITL variables[1]. [0]: https://github.com/Josef-Friedrich/check_systemd/blob/main/contrib/icinga2/command.conf [1]: Josef-Friedrich/check_systemd#38 Co-Authored-By: RincewindsHat <[email protected]>
f988236
to
e7670e9
Compare
The executable name for check_systemd's dropped the
.py
suffix for version 2.0.31, released in April 20192. However, the old name is still being referenced, both in documentation as well as in the ITL's CheckCommand's command, making it unusable.Closes #9547.
Footnotes
https://github.com/Josef-Friedrich/check_systemd/compare/v2.0.2...v2.0.3#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7 ↩
https://github.com/Josef-Friedrich/check_systemd/releases/tag/v2.0.3 ↩