Small style improvements in FileOutputWindow and QuadEdgeMesh
#4939
+4
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Core
dzenanz
reviewed
Nov 7, 2024
vfonov
reviewed
Nov 7, 2024
There was a problem hiding this comment.
I was trying to make sign flip clearly visible.
There was a problem hiding this comment.
OK, thanks @vfonov Of course I can revert my proposed adjustment, if you want to. But still... what would you think of _sep *= -1.0 (instead of your original _sep = -_sep)?
hjmjohnson
approved these changes
Nov 8, 2024
dzenanz
approved these changes
Nov 8, 2024
N-Dekker
commented
Nov 8, 2024
|
Converted back to draft, because there appears no consensus on my proposed removal of |
`m_Stream` is a non-static member of `itk::FileOutputWindow`, so it cannot be accessed anymore when the FileOutputWindow object is destructed.
Found by the regular expression `(\w+ \*)([ ]+\w+ = )\(\1\)nullptr`. Following C++ Core Guidelines, Oct 3, 2024, "Avoid casts", http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es48-avoid-casts
N-Dekker
force-pushed
the
Style-MINCImageIO-QuadEdgeMesh-FileOutputWindow
branch
from
e45c110
to
aa38494
Compare
|
Update: Just dropped the commit STYLE: Remove |
N-Dekker
changed the title
MINCImageIO, FileOutputWindow, QuadEdgeMeshFileOutputWindow and QuadEdgeMesh
dzenanz
approved these changes
Nov 12, 2024
hjmjohnson
merged commit 1b41e94
into
InsightSoftwareConsortium:master
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess these
threetwo commits are rather trivial. They just address some little cases that I noticed when doing larger pull requests, specifically:T var; var = xwithT var = xfor arithmetic types #4932T * p; p = xwithT * p = x, useauto *for variables initialized by a pointer cast #4937