Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small style improvements in FileOutputWindow and QuadEdgeMesh #4939

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Small style improvements in FileOutputWindow and QuadEdgeMesh #4939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b03240a
STYLE: Remove `m_Stream = nullptr` from destructor of `FileOutputWindow`
N-Dekker Nov 7, 2024
aa38494
STYLE: Remove C-style cast from `nullptr` default arguments QuadEdgeMesh
N-Dekker Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Modules/Core/Common/src/itkFileOutputWindow.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ FileOutputWindow::FileOutputWindow()
FileOutputWindow::~FileOutputWindow()
{
delete m_Stream;
m_Stream = nullptr;
dzenanz marked this conversation as resolved.
Show resolved Hide resolved
}

void
Expand Down
4 changes: 1 addition & 3 deletions Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshBaseIterator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,9 +275,7 @@ class ITK_TEMPLATE_EXPORT QuadEdgeMeshIteratorGeom : public QuadEdgeMeshIterator
using OriginRefType = typename QuadEdgeType::OriginRefType;

public:
QuadEdgeMeshIteratorGeom(QuadEdgeType * e = (QuadEdgeType *)nullptr,
int op = Superclass::OperatorOnext,
bool start = true)
QuadEdgeMeshIteratorGeom(QuadEdgeType * e = nullptr, int op = Superclass::OperatorOnext, bool start = true)
: Superclass(e, op, start)
{}

Expand Down
11 changes: 3 additions & 8 deletions Modules/Core/QuadEdgeMesh/include/itkQuadEdgeMeshFrontIterator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,7 @@
using FrontIterator = QuadEdgeMeshFrontIterator<MeshTypeArg, QEPrimalType>; \
using ConstFrontIterator = QuadEdgeMeshConstFrontIterator<MeshTypeArg, QEPrimalType>; \
\
virtual FrontIterator BeginFront(QEPrimalType * seed = (QEPrimalType *)nullptr) \
{ \
return (FrontIterator(this, true, seed)); \
} \
virtual FrontIterator BeginFront(QEPrimalType * seed = nullptr) { return (FrontIterator(this, true, seed)); } \
\
virtual ConstFrontIterator BeginFront(QEPrimalType * seed) const { return (ConstFrontIterator(this, true, seed)); } \
\
Expand Down Expand Up @@ -149,9 +146,7 @@ class ITK_TEMPLATE_EXPORT QuadEdgeMeshFrontBaseIterator

public:
/** Object creation methods. */
QuadEdgeMeshFrontBaseIterator(MeshType * mesh = (MeshType *)nullptr,
bool start = true,
QEType * seed = (QEType *)nullptr);
QuadEdgeMeshFrontBaseIterator(MeshType * mesh = nullptr, bool start = true, QEType * seed = nullptr);
virtual ~QuadEdgeMeshFrontBaseIterator();

Self &
Expand Down Expand Up @@ -242,7 +237,7 @@ class ITK_TEMPLATE_EXPORT QuadEdgeMeshFrontIterator : public QuadEdgeMeshFrontBa

public:
/** Object creation methods. */
QuadEdgeMeshFrontIterator(MeshType * mesh = (MeshType *)0, bool start = true, QEType * seed = (QEType *)nullptr)
QuadEdgeMeshFrontIterator(MeshType * mesh = (MeshType *)0, bool start = true, QEType * seed = nullptr)
: Superclass(mesh, start, seed)
{}
~QuadEdgeMeshFrontIterator() override = default;
Expand Down