-
Notifications
You must be signed in to change notification settings - Fork 63
Fix missing runtime dependencies (pyarrow, kuzu) #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @mdjhacker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves critical runtime failures by explicitly adding Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes runtime errors by adding missing kuzu and pyarrow dependencies to requirements.txt. My review focuses on improving dependency management practices. I've suggested pinning the versions of the new dependencies to ensure reproducible builds. I also provided recommendations for long-term improvements, such as using ray extras for pyarrow and considering extras_require in setup.py for optional storage backends.
| kuzu | ||
| pyarrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the missing dependencies. To improve dependency management and ensure reproducible builds, I have a couple of suggestions:
-
Pin dependency versions: It's a best practice to pin dependency versions (e.g.,
kuzu==X.Y.Z) to prevent your application from breaking when a new version of a dependency is released. Please add version specifiers forkuzuandpyarrow. -
Manage
pyarrowviarayextras:pyarrowis a dependency ofray.data. The idiomatic way to manage this is to specify it as an extra forray, likeray[data]==2.52.1. This automatically pulls in the correctpyarrowversion. While theraydependency line isn't in this diff, I recommend creating a follow-up task to make this change for better dependency management.
For this PR, please at least pin the versions of the newly added dependencies.
|
Thanks, LGTM. |
Problem
Running the following command fails at runtime due to missing dependencies:
Error 1: missing
pyarrowray.datarequirespyarrow, but it is not explicitly declared or checked, causing an import-time crash.Error 2: missing
kuzuThis error occurs during
GraphStorageActorinitialization, after part of the pipeline has already started, leading to Ray actor failure.Fix
pyarrowandkuzutorequirements.txtto resolve runtime import errors inray.dataandGraphStorageActor.