Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ aiohttp
socksio
pydantic
ray==2.52.1
kuzu
pyarrow
Comment on lines +26 to +27
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for adding the missing dependencies. To improve dependency management and ensure reproducible builds, I have a couple of suggestions:

  1. Pin dependency versions: It's a best practice to pin dependency versions (e.g., kuzu==X.Y.Z) to prevent your application from breaking when a new version of a dependency is released. Please add version specifiers for kuzu and pyarrow.

  2. Manage pyarrow via ray extras: pyarrow is a dependency of ray.data. The idiomatic way to manage this is to specify it as an extra for ray, like ray[data]==2.52.1. This automatically pulls in the correct pyarrow version. While the ray dependency line isn't in this diff, I recommend creating a follow-up task to make this change for better dependency management.

For this PR, please at least pin the versions of the newly added dependencies.


leidenalg
igraph
Expand Down