Reorganised ouroboros-network packages

[coot]

Description

• Moved ouroboros-network-protocols to ouroboros-network
• Moved ouroboros-network-framework to ouroboros-newtork:framework
• Moved ouroboros-network-mock to ouroboros-network:mock
• Reorganised ouroboros-network.cabal file
• Moved ouroboros-network-testing to ouroboros-network
• Moved ouroboros-network-api to ouroboros-newtork
• ouroboros-network:api - moved NodeTo{Node,Client} under Cardano name space
• ouroboros-network:api-tests - moved NodeTo{Client,Node}.Version tests
• ouroboros-network:api-tests - moved Test.Cardano.Network.Version
• ouroboros-network:mock - moved its last module to protocols-tests-lib
• cardano-diffusion package
• peer-selection: reorganised exports
• Updated nix & GHA
• Added changelog
• Updated network-spec

Checklist

Quality

• Commit sequence makes sense and have useful messages, see ref.
• New tests are added and existing tests are updated.
• Self-reviewed the PR.

Maintenance

• Linked an issue or added the PR to the current sprint of ouroboros-network project.
• Added labels.
• Updated changelog files.
• The documentation has been properly updated, see ref.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[crocodile-dentist]

Can we remove the commit sim-net: removed duplicate traces. When debugging I want to have the flexibility to just enable the say tracer of interest and really cut down on the noise, but with this change it will be all or nothing. The node tracer is iosimTracer and in fact I comment out the second term:

-- | A debug tracer which embeds events in DiffusionTestTrace.
--
iosimTracer :: forall s.
               Tracer (IOSim s) (WithTime (WithName NtNAddr DiffusionTestTrace))
iosimTracer =
     Tracer traceM
--  <> Tracer (\WithTime { wtEvent = WithName { wnName, wnEvent } } ->
--              -- don't log time, it's in the trace
--              say $ ppNtNAddr wnName ++ " @ " ++ ppDiffusionTestTrace wnEvent)

[edit] to avoid the issue of double trace output, maybe we can switch our counterexamples:

-    $ counterexample (Trace.ppTrace show (ppSimEvent 0 0 0) $ Trace.take traceNumber trace)
+    $ counterexample (List.intercalate "\n" $
+        selectTraceEventsSay' $ Trace.take traceNumber trace)

[crocodile-dentist]

The commit Removed DuplicateRecordFields extension can instead enable the extension DisambiguateRecordFields and we won't have to prefix every field of a record with the module it's from (eg. IG, or Diffusion, and maybe some others as well).

[crocodile-dentist]

just one comment and one request

[coot]

Can we remove the commit sim-net: removed duplicate traces. When debugging I want to have the flexibility to just enable the say tracer of interest and really cut down on the noise, but with this change it will be all or nothing. The node tracer is iosimTracer and in fact I comment out the second term:

Good point, I'll drop this commit from this PR.