typed-protocol's annotated driver: bugfix #5207
Merged
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
force-pushed
the
mw/bugfix-runannotateddecoder
branch
3 times, most recently
from
7659b22 to
7f73f2a
Compare
coot
added
typed-protocols
crocodile-dentist
force-pushed
the
mw/bugfix-runannotateddecoder
branch
2 times, most recently
from
e38360a to
24d28d8
Compare
crocodile-dentist
removed this pull request from the merge queue due to a manual request
Using maybeToList will cause the accumulator to hold the trailing bytes twice. This will result in the annotator grabbing the wrong fragments in raw format. The messages will decode properly; however if these raw fragments are forwarded to other peers, they will be rejected and the remote will close the connection.
crocodile-dentist
force-pushed
the
mw/bugfix-runannotateddecoder
branch
from
24d28d8 to
c81eb70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using maybeToList will cause the accumulator to hold the trailing bytes twice.
This will result in the annotator grabbing the wrong
fragments in raw format. The messages will decode properly; however
if these raw fragments are forwarded to other peers, they will be
rejected and the remote will close the connection.
Formerly there were changes to testing code in this PR, but a different approach will be taken
after input-output-hk/typed-protocols#76
Checklist
Quality
Maintenance
ouroboros-networkproject.